Re: [9front] [patch] nusb/audio /dev entries fix v2

[cinap_lenrek@felloff.net]

>	int dir = e->dir;
> 	Aconf *c;
> 	Range *f;
>+	char buf[32];
> 
> 	for(;e != nil; e = e->next){
> 		c = e->iface->aux;
>@@ -395,9 +396,12 @@
> 	devctl(d, "sampledelay %d", audiodelay);
> 	devctl(d, "hz %d", speed);
> 	if(e->dir==Ein)
>-		devctl(d, "name audioin");
>+		snprint(buf, sizeof buf, "name audioinU%s", audiodev->hname); 
> 	else
>-		devctl(d, "name audio");
>+		snprint(buf, sizeof buf, "name audioU%s", audiodev->hname);
>+	
>+	devctl(d, buf);
>+

devctl() takes a format string, so the temporary buffer is not needed.
(also avoiding format string injection from hname).

the idea is good tho.

one catch i can see is what happens when you dont have a built-in
soundcard (#A) at all?

then you have no place to bind it to :(

maybe a solution could be to have this handled by mixfs?

like we could add an argument to mixfs to pass the name of
the audio device (defaulting to /dev/audio).

or even have mixfs being able to switch output devices with
a volue message by reading /dev/audio*.

if you don't want to use mixfs, you can use aux/stub
to the rescue.

let me look into mixfs solution...

--
cinap