Aw: Re: [9front] [PATCH] awk: don't write an extra NUL past the end of a block

[Alexander Shendi <Alexander.Shendi@web.de>]

Hi,


DISCLAIMER:
i haven't seen either the code of 9front's awk or onetrueawk's code.

However that doesn't keep me from speculating. I suspect the fields are stored as an array of NUL-terminated strings itself terminated by a NUL char. So you would need to allocate n+2 bytes for the last field.



> Gesendet: Dienstag, den 23.01.2024 um 18:50 Uhr
> Von: "Jacob Moody" <moody@posixcafe.org>
> An: 9front@9front.org
> Betreff: Re: [9front] [PATCH] awk: don't write an extra NUL past the end of a block
>
> On my linux machine:
> # nawk is onetrueawk
> ; dd </dev/zero bs=4 count=8k | tr '\0' A | nawk '{a=$1}'
> 8192+0 records in
> 8192+0 records out
> 32768 bytes (33 kB, 32 KiB) copied, 0.00933006 s, 3.5 MB/s
>
> This works fine. No crash. I am not doubting this needs fixed,
> I am doubtful of fixing it in this way being correct. It is still
> not clear to me if there is some other input that is relying on
> that extra line to be there. But it is clear that onetrueawk fixed
> this using some other fix.
>
> We should figure out how they solved it and/or prove that the cases
> in which those loops never run are impossible to hit.
>