From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 2293 invoked from network); 26 Mar 2022 10:44:40 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 26 Mar 2022 10:44:40 -0000 Received: by lists.zx2c4.com (OpenSMTPD) with ESMTP id 9db4d1b6; Sat, 26 Mar 2022 10:44:24 +0000 (UTC) Return-Path: Received: from mail.thenautilus.net (mail.thenautilus.net [5.79.87.27]) by lists.zx2c4.com (OpenSMTPD) with ESMTPS id 64ad2cd0 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Sat, 26 Mar 2022 10:44:22 +0000 (UTC) Received: (qmail 785 invoked from network); 26 Mar 2022 10:44:13 -0000 Received: from unknown (HELO nautilus) (dakkar@::ffff:81.2.107.215) by 0 with ESMTPA; 26 Mar 2022 10:44:13 -0000 Date: Sat, 26 Mar 2022 10:44:12 +0000 From: Gianni Ceccarelli To: cgit@lists.zx2c4.com Subject: Re: Weird interactions betwen cache and module-link Message-ID: <20220326104412.22146718@nautilus> In-Reply-To: References: <20220325210816.6f89abb3@thenautilus.net> <20220325214448.244a6590@thenautilus.net> X-Mailer: Claws Mail 4.0.0git409 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/ZqN.D=IzEFibvwWvruNpX+B" X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" --MP_/ZqN.D=IzEFibvwWvruNpX+B Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2022-03-26 John Keeping wrote: > Would you like to type up a proper patch with a commit message and > Signed-off-by certification? Sure! Patch attached. -- Dakkar - GPG public key fingerprint = A071 E618 DD2C 5901 9574 6FE2 40EA 9883 7519 3F88 key id = 0x75193F88 --MP_/ZqN.D=IzEFibvwWvruNpX+B Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-cgit.c-teach-repo-config-printing-about-per-path-mod.patch >From 9c8f12809a7727b19a111d717b27143c4e2001bd Mon Sep 17 00:00:00 2001 From: dakkar Date: Sat, 26 Mar 2022 10:39:45 +0000 Subject: [PATCH] cgit.c: teach repo config printing about per-path module-link This prevented path-specific module-links from working when cache was enabled, since the cache repo config didn't include them. Signed-off-by: Gianni Ceccarelli --- cgit.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cgit.c b/cgit.c index 08d81a1..ae3a66e 100644 --- a/cgit.c +++ b/cgit.c @@ -810,6 +810,10 @@ static void print_repo(FILE *f, struct cgit_repo *repo) fprintf(f, "repo.extra-head-content=%s\n", repo->extra_head_content); if (repo->module_link) fprintf(f, "repo.module-link=%s\n", repo->module_link); + for_each_string_list_item(item, &repo->submodules) { + if (item->util) + fprintf(f, "repo.module-link.%s=%s\n", item->string, (char*)item->util); + } if (repo->section) fprintf(f, "repo.section=%s\n", repo->section); if (repo->homepage) -- 2.34.1 --MP_/ZqN.D=IzEFibvwWvruNpX+B--