List for cgit developers and users
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: cgit@lists.zx2c4.com
Subject: RFE: commit git-patch-id lookup links
Date: Fri, 7 Oct 2022 13:25:28 -0400	[thread overview]
Message-ID: <20221007172528.4ryaoc26wwtsetdw@meerkat.local> (raw)

Hi, all:

One of the recent additions to public-inbox was auto-indexing of patches by
their patch-id (see git-patch-id.1). This allows to see a history of many
commits through public-inbox discussions. Using a random commit as an example:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e4dc45b1848bc6bcac31eb1b4ccdd7f6718b3c86

We can convert it to a patch-id and look up its history:

$ echo "https://lore.kernel.org/all/?q=patchid:$(git show e4dc45b1848 | git patch-id --stable | awk '{print $1}')"
https://lore.kernel.org/all/?q=patchid:d91c951338cfe9f06e8b8aa74856f6dc08ac8212

It would be nice to have this feature in cgit:

1. add "patch-id-query-url" parameter, e.g.:

   patch-id-query-url=https://lore.kernel.org/all/?q=patchid:%s

2. when defined, commit views would add another entry in the header table:

   <tr>
     <th>code-review</th>
     <td colspan='2' class='sha1'><a href='https://lore.kernel.org/all/?q=patchid:${patchid}'>patchid:${patchid}</a><br/></td>
   </tr>

This would only make sense for non-merge commits (i.e. those with fewer than 2
parents).

Thoughts?

-K

             reply	other threads:[~2022-10-07 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 17:25 Konstantin Ryabitsev [this message]
2022-10-07 21:14 ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221007172528.4ryaoc26wwtsetdw@meerkat.local \
    --to=konstantin@linuxfoundation.org \
    --cc=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).