tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: "Anthony J. Bentley" <anthony@anjbe.name>
To: tech@mdocml.bsd.lv
Subject: Double quotes in man.cgi search output
Date: Tue, 30 Aug 2016 01:43:59 -0600	[thread overview]
Message-ID: <35268.1472543039@CATHET.us> (raw)

Hi,

html_putchar() escapes double quotes incorrectly: the entity should be
&quot;, not &quote;.

https://www.w3.org/TR/html5/syntax.html#named-character-references

For example:

http://man.openbsd.org/?query=Nd~%22&apropos=1

In Firefox, each &quote; is rendered as: "e;
because Firefox believes what the author meant to write was &quot;e;

Index: cgi.c
===================================================================
RCS file: /cvs/src/usr.bin/mandoc/cgi.c,v
retrieving revision 1.77
diff -u -p -r1.77 cgi.c
--- cgi.c	18 Aug 2016 00:44:37 -0000	1.77
+++ cgi.c	30 Aug 2016 07:34:28 -0000
@@ -136,7 +136,7 @@ html_putchar(char c)
 
 	switch (c) {
 	case ('"'):
-		printf("&quote;");
+		printf("&quot;");
 		break;
 	case ('&'):
 		printf("&amp;");
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

             reply	other threads:[~2016-08-30  7:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30  7:43 Anthony J. Bentley [this message]
2016-09-11 23:57 ` Ingo Schwarze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35268.1472543039@CATHET.us \
    --to=anthony@anjbe.name \
    --cc=tech@mdocml.bsd.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).