From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 427 invoked from network); 1 Oct 2020 05:47:50 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 1 Oct 2020 05:47:50 -0000 Received: (qmail 14161 invoked by uid 550); 1 Oct 2020 05:47:45 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 14143 invoked from network); 1 Oct 2020 05:47:45 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to; bh=Os0kwHaWP4HngQKYbZ8BW7H6jfxa0Ee65qFqt2XMUT4=; b=movf5rdT4Ay9elSP0SpiuQlsDTlYi7oAO76+9Hg1LwREU3DP0dDaB1njKjmZyI+xrf oBPPfWYpBgeiOnVKJkYmMIAa752TOhEkCjMpU83bW7vPoxKyKN/bBtZ8qTl+pJlZdni+ rV2GrMz8kbPWZ0Huo6xcE0KIXbjdB3z14RQ692oPhRobXZjweY37IbXT0Vv8qwD9zrD1 IQYnbZ2aj/panNItCoXDjDVAFvxt6UfT2UbeQKwt+t+0vMNGppfrW2UxGkYB7tCRDa9q kmoAbpR98H3Cd1jYLRasqqeo1AmM5zPnMPkAppVZTjhxKfELfZDFsAaU2V4WhFj4hg0Q hZpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to; bh=Os0kwHaWP4HngQKYbZ8BW7H6jfxa0Ee65qFqt2XMUT4=; b=WWQMJYGa10epJQJ2RHIki2vYkw3ErbR+TAjBTzqzEj5jpPrf8QbHbNKP29qKjSlC9B Lau4o38tGeyhfZV1TVpWzXH0euUeZ6kC1VyDyzcxjx65xE+MnMP9YnCzTj8+JNdrnqlV LSEAIl4dLMYspDx22Bn6myuD4ZLaen7Z05Pc6Y8R/F3HjhFpiMdoBTryn1Fy8KQOPB0a IOGqZRMrpksHDumJfRcUBqHV0N575fmOylziyOtUhyDevKdxpPdtx+SDejr5ZwWZKrzk 0cR+xjKZlf2+v0IP/FJPoTCGK4p7g8mNaEQzEHWATt1bzgodtBKlSF6zug2r5jVivSMX LTjg== X-Gm-Message-State: AOAM530HHaj5dfO0RqXqrf6pxzqmt+Sgh4TBWqURN50I7nJ7FryLGkB2 szgAZB0Pz42OUHnmDviHIZQ= X-Google-Smtp-Source: ABdhPJxBNhhTY4Zg2XMcQTPQrWirIlnMmF+6K4YNVTBI+XdqwbftodApQvwSYLHUpoHBkkBCGT1l5A== X-Received: by 2002:a17:906:3a0e:: with SMTP id z14mr6220594eje.192.1601531254120; Wed, 30 Sep 2020 22:47:34 -0700 (PDT) Date: Thu, 1 Oct 2020 07:47:31 +0200 From: Petr Vorel To: Rich Felker Cc: linux-kernel@vger.kernel.org, musl@lists.openwall.com Message-ID: <20201001054731.GA193908@x230> References: <20200930214636.186132-1-petr.vorel@gmail.com> <20200930234212.GK17637@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200930234212.GK17637@brightrain.aerifal.cx> Subject: Re: [musl] [PATCH 1/1] linux/sysinfo.h: Add guarder for struct sysinfo Hi Rich, ... > I don't think this is the right way to do it. It prevents getting > access to the kernel uapi structure (which may be wanted) if you're > not using glibc or if you include kernel headers before any libc > headers. Rather, , whose only real purpose is > providing this structure to legacy applications that don't know the > renamed name for it, should not be implicitly included by other > headers. There's an existing thread on the topic but I don't have the > link handy. IIRC I proposed moving the alignment macros or whatever > other useful stuff is in to a separate header and > getting rid of all the indirect inclusions of . Thanks for a review and tip! Kind regards, Petr