From: Fangrui Song <i@maskray.me>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] crt: Add .file directive
Date: Fri, 30 Oct 2020 13:54:16 -0700 [thread overview]
Message-ID: <20201030205416.l6mx5gtx6pftz2fw@gmail.com> (raw)
In-Reply-To: <20201030185016.GD534@brightrain.aerifal.cx>
On 2020-10-30, Rich Felker wrote:
>On Fri, Oct 30, 2020 at 11:44:02AM -0700, Khem Raj wrote:
>> Musl linked binaries come out to be not reproducible because
>> absolute build path is seen in debug info of crti.o and crtn.o
>> This is due to the fact that these objects are built from assembly
>> source files and they are missing .file directive
>> if we add .file <filename>.s in them then debug info encodes this
>> value instead of absolute path in debug_line section
.debug_line is unrelated because there is no .loc directive in these
crti.s and crtn.s files.
Many architectures do not leave non-STT_SECTION STB_LOCAL symbols in
crti.o and crtn.o, so they don't need to be patched (even if the
maintainer agrees to add the workaround in musl, instead of fixing the
toolchain).
>Surely there should be some better way to achieve this with CFLAGS
>instead of duplication across every source file..?
>
>Rich
https://bugs.llvm.org/show_bug.cgi?id=48023 captures the nature of the
problem. You may send a message to binutils@sourceware.org how GCC/gas
should handle this situation.
LLD and gold do not synthesize STT_FILE, hence no such problem.
next prev parent reply other threads:[~2020-10-30 20:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 18:44 Khem Raj
2020-10-30 18:50 ` Rich Felker
2020-10-30 20:54 ` Fangrui Song [this message]
2021-01-04 20:08 ` Fangrui Song
2021-01-05 2:11 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030205416.l6mx5gtx6pftz2fw@gmail.com \
--to=i@maskray.me \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).