Re: [musl] [PATCH] nftw: implement FTW_ACTIONRETVAL

[Rich Felker <dalias@libc.org>]

On Fri, Mar 26, 2021 at 02:44:56PM +0900, Dominique Martinet wrote:
> nftw is sometimes used with e.g. FTW_SKIP_SUBTREE on linux which
> requires special handling.
> 
> A similar patch was sent in 2018[1] and general feedbacks for nftw
> seemed positive, but the original work's license was not clear so this
> implementation was made without using it, looking at the linux man page
> and comparing with glibc's behaviour through test programs.
> 
> [1] https://www.openwall.com/lists/musl/2018/12/16/1

Feedback for that submission as a whole was negative because it was
just "throw in everything I found that systemd wanted", which is a
policy discussion that's already been had and the answer is no.
However that's not a judgement on any individual feature like
FTW_ACTIONRETVAL, which could meet criteria for inclusion. I haven't
gotten a good chance to look at this yet, but if you haven't already,
could you post some supporting reasons for this (like widespread usage
by applications that you've found)? That would help determine if it's
appropriate.

Rich