Re: [musl] [PATCH v2 1/8] bits/syscall.h: add process_madvise from linux v5.14

[Rich Felker <dalias@libc.org>]

On Sun, Feb 18, 2024 at 03:26:43AM +0100, Gaël PORTAY wrote:
> see
> 
>     linux commit 7bb7f2ac24a028b20fca466b9633847b289b156a
>     arch, mm: wire up memfd_secret system call where relevant
> 
>     linux commit 1507f51255c9ff07d75909a84e7c0d7f3c4b2f49
>     mm: introduce memfd_secret system call to create "secret" memory areas
> 
>     linux commit b633896314c0f78f2b4eb7b19a530d68f2a35445
>     tools headers UAPI: Sync s390 syscall table file that wires up the memfd_secret syscall
> ---
>  arch/aarch64/bits/syscall.h.in    | 1 +
>  arch/arm/bits/syscall.h.in        | 1 +
>  arch/i386/bits/syscall.h.in       | 1 +
>  arch/m68k/bits/syscall.h.in       | 1 +
>  arch/microblaze/bits/syscall.h.in | 1 +
>  arch/mips/bits/syscall.h.in       | 1 +
>  arch/mips64/bits/syscall.h.in     | 1 +
>  arch/mipsn32/bits/syscall.h.in    | 1 +
>  arch/or1k/bits/syscall.h.in       | 1 +
>  arch/powerpc/bits/syscall.h.in    | 1 +
>  arch/powerpc64/bits/syscall.h.in  | 1 +
>  arch/riscv64/bits/syscall.h.in    | 1 +
>  arch/s390x/bits/syscall.h.in      | 1 +
>  arch/sh/bits/syscall.h.in         | 1 +
>  arch/x32/bits/syscall.h.in        | 1 +
>  arch/x86_64/bits/syscall.h.in     | 1 +
>  16 files changed, 16 insertions(+)
> 
> diff --git a/arch/aarch64/bits/syscall.h.in b/arch/aarch64/bits/syscall.h.in
> index 5f420e61..88512ec9 100644
> --- a/arch/aarch64/bits/syscall.h.in
> +++ b/arch/aarch64/bits/syscall.h.in
> @@ -299,4 +299,5 @@
>  #define __NR_landlock_create_ruleset	444
>  #define __NR_landlock_add_rule	445
>  #define __NR_landlock_restrict_self	446
> +// reserved for memfd_secret	447
> [...]

This patch seems mistitled, and should avoid introducing comments
(especially // form which are c89-incompatible) into an installed
header. I've renamed it to:

"bits/syscall.h: add memfd_secret from linux v5.14"

and removed the comments.

(No need to resubmit)

Rich