From: Szabolcs Nagy <nsz@port70.net>
To: Damian McGuckin <damianm@esi.com.au>
Cc: MUSL <musl@lists.openwall.com>
Subject: Re: [musl] Re: cacosh.c - Comment needs correction
Date: Sat, 9 Mar 2024 21:23:19 +0100 [thread overview]
Message-ID: <20240309202319.GE1884416@port70.net> (raw)
In-Reply-To: <ef75efa8-594d-4864-d566-ab8f3ae2f535@esi.com.au>
* Damian McGuckin <damianm@esi.com.au> [2024-03-08 15:44:32 +1100]:
> On Fri, 8 Mar 2024, Damian McGuckin wrote:
>
> >
> > The routine produces the correct answer.
> >
> > However, currently, the comment at the top says
> >
> > /* acosh(z) = i acos(z) */
> >
> > I believe this is technically wrong;
> >
> > To reflect the code, it should be changed to something like:
> >
> > /* cacosh(z) = acosh(x +/- i y) = +/- i acos(x + i y) */
>
> Sorry (fat fingers or worse):
>
> /* cacosh(z) = acosh(x +/- i y) = +/- i acos(x +/- i y) */
>
according to section 6.2 of
https://cs.uwaterloo.ca/~smwatt/pub/reprints/2000-sigsam-according.pdf
acosh(z) = +-i acos(z)
with + when Im(z)>0 or Im(z)==0 && Re(z)<=1
i guess the Im(z)==+0 && Re(z)>1 case is tricky with ieee -0.0 as it
depends on if sqrt(-z) is i or -i for z=1, which depends on if pure
reals are treated specially sqrt(-1)==i or as sqrt(-1-0i)==-i, in the
latter case the current code looks right to me, just the comment wrong.
> Thanks - Damian
>
> Pacific Engineering Systems International ..... 20D Grose St, Glebe NSW 2037
> Ph:+61-2-8571-0847 .. Fx:+61-2-9692-9623 | unsolicited email not wanted here
> Views & opinions here are mine and not those of any past or present employer
next prev parent reply other threads:[~2024-03-09 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 4:20 [musl] " Damian McGuckin
2024-03-08 4:44 ` [musl] " Damian McGuckin
2024-03-09 20:23 ` Szabolcs Nagy [this message]
2024-03-09 21:56 ` Damian McGuckin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240309202319.GE1884416@port70.net \
--to=nsz@port70.net \
--cc=damianm@esi.com.au \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).