mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: busybox@busybox.net, musl@lists.openwall.com
Cc: Waldemar Brodkorb <wbx@openadk.org>
Subject: [musl] Busybox hwclock failing to build with musl RISC-V 32-bit: SYS_settimeofday undefined
Date: Sun, 7 Apr 2024 19:18:48 +0200	[thread overview]
Message-ID: <20240407191848.5c811765@windsurf> (raw)

Hello,

The recently released musl 1.2.5 includes 32-bit RISC-V support. Turns
out that building Busybox 1.36.1 with this new musl version, on 32-bit
RISC-V, fails with:

util-linux/hwclock.c: In function 'set_kernel_tz':
util-linux/hwclock.c:142:27: error: 'SYS_settimeofday' undeclared (first use in this function); did you mean 'xsettimeofday'?
  142 |         int ret = syscall(SYS_settimeofday, NULL, tz);
      |                           ^~~~~~~~~~~~~~~~
      |                           xsettimeofday
util-linux/hwclock.c:142:27: note: each undeclared identifier is reported only once for each function it appears in

Busybox already includes some slightly convoluted sorcery to deal with
musl:

static void set_kernel_tz(const struct timezone *tz)
{
#if LIBC_IS_MUSL
	/* musl libc does not pass tz argument to syscall
	 * because "it's deprecated by POSIX, therefore it's fine
	 * if we gratuitously break stuff" :(
	 */
#if !defined(SYS_settimeofday) && defined(SYS_settimeofday_time32)
# define SYS_settimeofday SYS_settimeofday_time32
#endif
	int ret = syscall(SYS_settimeofday, NULL, tz);
#else
	int ret = settimeofday(NULL, tz);
#endif
	if (ret)
		bb_simple_perror_msg_and_die("settimeofday");
}

I am not sure whether this is a Busybox problem or a musl problem,
which is why I'm cross-posting on both mailing lists.

Thanks a lot in advance for your feedback,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com

             reply	other threads:[~2024-04-07 17:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-07 17:18 Thomas Petazzoni [this message]
2024-04-07 17:37 ` Markus Wichmann
2024-04-07 19:50   ` Markus Wichmann
2024-04-08  2:18 ` Rich Felker
  -- strict thread matches above, loose matches on Subject: below --
2024-03-03 14:36 Thomas Petazzoni
2024-03-03 15:17 ` Rich Felker
2024-03-05 20:30   ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240407191848.5c811765@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=busybox@busybox.net \
    --cc=musl@lists.openwall.com \
    --cc=wbx@openadk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).