From: Michael Forney <mforney@mforney.org>
To: Jens Gustedt <Jens.Gustedt@inria.fr>
Cc: musl@lists.openwall.com
Subject: [musl] Re: [PATCH] C23: update some legacy function pointers
Date: Mon, 15 Apr 2024 20:57:35 -0700 [thread overview]
Message-ID: <29L5XTRHVUHVF.2NI3H53T4EFFS@mforney.org> (raw)
In-Reply-To: <20240319151202.6856ebec@inria.fr>
Jens Gustedt <Jens.Gustedt@inria.fr> wrote:
> In C23, empty parameter lists loose their meaning as "function that
> may receive any number of parameters".
>
> When compiling with -std=c2x, there were three left-overs in musl that
> still used that. Change them to use the correct prototype, since it is
> available at all these places, anyhow.
I think there's one more:
diff --git a/src/process/posix_spawn.c b/src/process/posix_spawn.c
index 8294598b..e05f1623 100644
--- a/src/process/posix_spawn.c
+++ b/src/process/posix_spawn.c
@@ -149,7 +149,7 @@ static int child(void *args_vp)
? &attr->__mask : &args->oldmask, 0);
int (*exec)(const char *, char *const *, char *const *) =
- attr->__fn ? (int (*)())attr->__fn : execve;
+ attr->__fn ? (int (*)(const char *, char *const *, char *const *))attr->__fn : execve;
exec(args->path, args->argv, args->envp);
ret = -errno;
Perhaps it's better to solve this by changing the type of __fn in
posix_spawnattr_t from void * to the appropriate function type, but
since this is in a public header, I'm not sure if it somehow breaks
something:
diff --git a/include/spawn.h b/include/spawn.h
index 8eb73e00..fec1280d 100644
--- a/include/spawn.h
+++ b/include/spawn.h
@@ -29,7 +29,7 @@ typedef struct {
pid_t __pgrp;
sigset_t __def, __mask;
int __prio, __pol;
- void *__fn;
+ int (*__fn)(const char *, char *const *, char *const *);
char __pad[64-sizeof(void *)];
} posix_spawnattr_t;
diff --git a/src/process/posix_spawn.c b/src/process/posix_spawn.c
index 8294598b..2611fb94 100644
--- a/src/process/posix_spawn.c
+++ b/src/process/posix_spawn.c
@@ -149,7 +149,7 @@ static int child(void *args_vp)
? &attr->__mask : &args->oldmask, 0);
int (*exec)(const char *, char *const *, char *const *) =
- attr->__fn ? (int (*)())attr->__fn : execve;
+ attr->__fn ? attr->__fn : execve;
exec(args->path, args->argv, args->envp);
ret = -errno;
diff --git a/src/process/posix_spawnp.c b/src/process/posix_spawnp.c
index aad6133b..28ef1aa4 100644
--- a/src/process/posix_spawnp.c
+++ b/src/process/posix_spawnp.c
@@ -8,6 +8,6 @@ int posix_spawnp(pid_t *restrict res, const char *restrict file,
{
posix_spawnattr_t spawnp_attr = { 0 };
if (attr) spawnp_attr = *attr;
- spawnp_attr.__fn = (void *)__execvpe;
+ spawnp_attr.__fn = __execvpe;
return posix_spawn(res, file, fa, &spawnp_attr, argv, envp);
}
next prev parent reply other threads:[~2024-04-16 3:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 14:12 [musl] C23 support, v11 Jₑₙₛ Gustedt
2024-04-16 3:57 ` Michael Forney [this message]
2024-04-16 13:42 ` [musl] Re: [PATCH] C23: update some legacy function pointers Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29L5XTRHVUHVF.2NI3H53T4EFFS@mforney.org \
--to=mforney@mforney.org \
--cc=Jens.Gustedt@inria.fr \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).