From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5474 invoked from network); 17 Feb 2021 19:53:48 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 17 Feb 2021 19:53:48 -0000 Received: (qmail 13744 invoked by uid 550); 17 Feb 2021 19:53:43 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 11806 invoked from network); 17 Feb 2021 19:49:57 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=U8/mv3fuwVKv5iNIRpVbvRMvE0Ck2E1zUO0P8V2zryA=; b=Qck6Q/55JrkPLzxA8MnwKE5ckNCipU63TG9zf8XRsa7nzn3sTcN9gYmK/3fCsHtCnL 0f6AOlb2zMOXrIsKUqHFhiu2whPrNX+uHjzJMeHq/kui5+YNFYBk5TKNF5FehDQAXGp1 +FP+1clP6YO5Y62jnAwXctSzAPtQ0JlW/pDsyoe31xZgNlIa+8DMNV5dTtVeNR5pwq2O AonSHpJSF+IWUEgDYkHickFfqsP7SfM49YkFE0/tfXU7T2sWX4Kjk+jDKk6A+OgWFOtl 8U045k5WbSwBJXPBhnd71721kOalltUod1pjnALbp31PWbz0svBIGi+ps+LLsH6Wa/IQ Xe7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=U8/mv3fuwVKv5iNIRpVbvRMvE0Ck2E1zUO0P8V2zryA=; b=NH/aMxSiN7eDK1UyQjcDc0oTjAGJFpXVP7kw1nOwoSzg6XnlsiXaqFUUFCs5s8UD2O jZ+Dtl5QSSCSF28fzMuDdksKE3veKdqYjSJL5aByYqXiYF/Mf8PmJZba0cOzQugAmzys xQWyNYccBMrhWrWIC1YVuYBQiUdslyUYqIct5N+NtAaBMeUzuQs6dNj42dbpUKPOexly +KPX2TG9k5vnYxMRWsxF1SZ4oZ6F6eaQR5VZmu5DqhaC9sPcL8QtSRVQzmwkZWCOBqCh ckRnCihmk7XbajhA30NNAzc8PiwFCKjuRBU7zS6YvmzRWWigM3Dxkwip4M+fKYKz7qAq NWiw== X-Gm-Message-State: AOAM531mIpFJ+gJP58/6ytRHvsbanK6l/ZY+z3/u+6fBytvVithyiRhb S9t+s/QJeHVmY1/VIjeKaEMbUCQ6s7w= X-Google-Smtp-Source: ABdhPJyXOXBDNC6IWMHNm+01p1UDOBH3KJR/vXefL/CuTJJf0v9w0ShFkhAiw/Fl635nLNQyb+IIfw== X-Received: by 2002:a37:556:: with SMTP id 83mr881283qkf.298.1613591385269; Wed, 17 Feb 2021 11:49:45 -0800 (PST) To: Rich Felker Cc: fweimer@redhat.com, musl@lists.openwall.com References: <62be4b85-4a42-413e-a83f-866eab4d601a@gmail.com> <20210203192145.GW23432@brightrain.aerifal.cx> <20210203210149.GX23432@brightrain.aerifal.cx> <20210203225518.GY23432@brightrain.aerifal.cx> <20210215165622.GF11590@brightrain.aerifal.cx> From: Dominic Chen Message-ID: <2e2e3693-b16a-d158-9617-99978a2b287f@gmail.com> Date: Wed, 17 Feb 2021 14:49:45 -0500 MIME-Version: 1.0 In-Reply-To: <20210215165622.GF11590@brightrain.aerifal.cx> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [musl] Incorrect thread TID caching On 2/15/2021 11:56 AM, Rich Felker wrote: > Following up on this now, the code in _Fork is something I really > don't want to duplicate for clone() for risk of forgetting there's a > copy in the latter and letting it bitrot there. I'd rather refactor > things so the same logic can be shared... Thanks for the update. Can you use something like __attribute__((always_inline)) to just write the logic once but force it to be inlined into both library functions? Dominic