From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id BB189216A8 for ; Fri, 8 Mar 2024 05:20:27 +0100 (CET) Received: (qmail 27881 invoked by uid 550); 8 Mar 2024 04:16:26 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 27846 invoked from network); 8 Mar 2024 04:16:25 -0000 Date: Fri, 8 Mar 2024 15:20:09 +1100 (AEDT) From: Damian McGuckin To: MUSL Message-ID: <7e3d7940-60c8-2df9-2441-7acee57d7ba@esi.com.au> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Subject: [musl] cacosh.c - Comment needs correction The routine produces the correct answer. However, currently, the comment at the top says /* acosh(z) = i acos(z) */ I believe this is technically wrong; To reflect the code, it should be changed to something like: /* cacosh(z) = acosh(x +/- i y) = +/- i acos(x + i y) */ Somebody may want to rephrase that, i.e. if the sign of 'y' is positive then the result is i * cacos(z) If the sign is negative, then the result is -i * cacos(z) I could always be wrong - Damian