From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id E98E0261AE for ; Sat, 9 Mar 2024 22:56:32 +0100 (CET) Received: (qmail 32012 invoked by uid 550); 9 Mar 2024 21:52:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 31973 invoked from network); 9 Mar 2024 21:52:27 -0000 Date: Sun, 10 Mar 2024 08:56:16 +1100 (AEDT) From: Damian McGuckin To: Szabolcs Nagy cc: MUSL In-Reply-To: <20240309202319.GE1884416@port70.net> Message-ID: <8469db8-b6a-ed58-32b-fe192deff4@esi.com.au> References: <7e3d7940-60c8-2df9-2441-7acee57d7ba@esi.com.au> <20240309202319.GE1884416@port70.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Subject: Re: [musl] Re: cacosh.c - Comment needs correction On Sat, 9 Mar 2024, Szabolcs Nagy wrote: > i guess the Im(z)==+0 && Re(z)>1 case is tricky with ieee -0.0 as it > depends on if sqrt(-z) is i or -i for z=1, which depends on if pure > reals are treated specially sqrt(-1)==i or as sqrt(-1-0i)==-i, in the > latter case the current code looks right to me, just the comment wrong. I agree. The code is correct. I thought I had said that. It is simply that the comment is slightly wrong. Thanks - Damian