mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Kate Deplaix <kit-ty-kate@outlook.com>
To: "musl@lists.openwall.com" <musl@lists.openwall.com>
Subject: [musl] Re: [PATCH] Increase NGROUPS_MAX from 32 to 1024
Date: Mon, 11 Mar 2024 18:31:13 +0000	[thread overview]
Message-ID: <CWXP265MB1368246ACA6778AC1ED35BF2BC242@CWXP265MB1368.GBRP265.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CWXP265MB1368231DFD26335D90664E77BCB2A@CWXP265MB1368.GBRP265.PROD.OUTLOOK.COM>

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

Hi,

Any chance this patch could be looked at?

Thanks,
Kate
________________________________
From: Kate Deplaix
Sent: 14 November 2023 23:35
To: musl@lists.openwall.com <musl@lists.openwall.com>
Subject: [PATCH] Increase NGROUPS_MAX from 32 to 1024

Such a restrictive value for NGROUPS_MAX makes it impossible to have a musl-based system with a user belonging to more than 32 groups. If done on the root user, this will break your system.
It also makes it impossible to use certain functions in binaries that have been compiled with musl.

This new value is still very far from Linux's NGROUPS_MAX of 65536 that has been there since Linux 2.6.4 but this is at least one tiny step in the right direction while maintainers investigate how to match Linux's value.

ref: https://www.openwall.com/lists/musl/2021/07/03/1
ref: https://www.openwall.com/lists/musl/2022/12/06/3
ref: https://github.com/ocaml/opam/pull/5383
---
 include/limits.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/limits.h b/include/limits.h
index 53a27b9d..501c3612 100644
--- a/include/limits.h
+++ b/include/limits.h
@@ -45,7 +45,7 @@
 #define NAME_MAX 255
 #endif
 #define PATH_MAX 4096
-#define NGROUPS_MAX 32
+#define NGROUPS_MAX 1024
 #define ARG_MAX 131072
 #define IOV_MAX 1024
 #define SYMLOOP_MAX 40
--
2.40.1

[-- Attachment #2: Type: text/html, Size: 2473 bytes --]

  reply	other threads:[~2024-03-11 18:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14 23:35 [musl] " Kate Deplaix
2024-03-11 18:31 ` Kate Deplaix [this message]
2024-03-12  0:46   ` [musl] " Rich Felker
2024-04-09 12:54     ` Kate Deplaix
2024-04-09 15:46       ` Thorsten Glaser
2024-04-09 16:26         ` Rich Felker
2024-04-11  1:07 ` [musl] " Rich Felker
2024-04-11  1:51   ` Rich Felker
2024-04-11  2:58   ` Markus Wichmann
2024-04-11 11:44     ` Laurent Bercot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CWXP265MB1368246ACA6778AC1ED35BF2BC242@CWXP265MB1368.GBRP265.PROD.OUTLOOK.COM \
    --to=kit-ty-kate@outlook.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).