mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Thorsten Glaser <tg@mirbsd.de>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] complex: fix comment in cacosh
Date: Sun, 10 Mar 2024 23:29:40 +0000 (UTC)	[thread overview]
Message-ID: <Pine.BSM.4.64L.2403102327040.18628@herc.mirbsd.org> (raw)
In-Reply-To: <20240310211906.GV4163@brightrain.aerifal.cx>

Rich Felker dixit:

>I'm fine with taking this patch as-is, but it naturally raises a
>question: should it instead be:
>
>-/* acosh(z) = i acos(z) */
>+/* acosh(z) = ±i acos(z) */

Yes, please.

>Really the only consideration for not doing this would be if it
>actively breaks compiling in some environments, but I don't think
>that's the case.

I’ve been using UTF-8 in comments in mksh for a while, and it
hasn’t broken on Minix, Plan 9, DEC ULTRIX, 4.4BSD on Windows,
Dell UNIX (bare SVR4), Haiku, Syllable OS, and a plethora of
other old, weird, and other systems. Even Xenix works… and an
EBCDIC system as well.

They just interpret it as pertaining to whatever the local
codepage is, and the EBCDIC system converted it as-if-it-were
“extended ASCII”, but it hasn’t broken anything.

IOW, I haven’t seen a nōn-8bit-clean C compiler yet. Nor sh.

bye,
//mirabilos
-- 
„Cool, /usr/share/doc/mksh/examples/uhr.gz ist ja ein Grund,
mksh auf jedem System zu installieren.“
	-- XTaran auf der OpenRheinRuhr, ganz begeistert
(EN: “[…]uhr.gz is a reason to install mksh on every system.”)

  reply	other threads:[~2024-03-10 23:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-10 20:00 Szabolcs Nagy
2024-03-10 21:19 ` Rich Felker
2024-03-10 23:29   ` Thorsten Glaser [this message]
2024-03-11  8:38   ` Szabolcs Nagy
2024-03-11  8:43     ` Damian McGuckin
2024-03-11 12:20       ` Gabriel Ravier
2024-03-11 13:15         ` Damian McGuckin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.BSM.4.64L.2403102327040.18628@herc.mirbsd.org \
    --to=tg@mirbsd.de \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).