From: Thorsten Glaser <tg@mirbsd.de>
To: musl@lists.openwall.com
Subject: Re: [musl] Potential bug in __res_msend_rc() wrt to union initialization.
Date: Thu, 21 Mar 2024 16:41:58 +0000 (UTC) [thread overview]
Message-ID: <Pine.BSM.4.64L.2403211637580.19384@herc.mirbsd.org> (raw)
In-Reply-To: <20240321115806.511a81cc@inria.fr>
Jₑₙₛ Gustedt dixit:
>As soon as you store
>to any member, padding bytes may change to arbitrary values.
Yes, but where is that a problem?
Something like:
union foo {
struct bar {
char *s;
size_t z;
} a;
struct baz {
size_t z;
char *s;
} b;
};
int
somefunc(int mode, char *buf, size_t len, …)
{
union foo u;
memset(u, '\0', sizeof(u));
/* … */
if (mode) {
/* from here on, u is decided to be a */
u.a.s = NULL;
} else {
/* from here on, u is decided to be b */
u.b.s = NULL;
}
/* … some other processing … */
if (mode) {
u.a.s = buf;
u.a.z = len;
} else {
u.b.s = buf;
u.b.z = len;
}
return (someotherfunc(&u, mode, …));
}
next prev parent reply other threads:[~2024-03-21 16:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 19:56 Mike Cui
2024-03-18 21:34 ` Rich Felker
2024-03-18 22:22 ` NRK
2024-03-18 22:39 ` [musl] Potential bug in __res_msend_rc() wrt to union initialisation Thorsten Glaser
2024-03-19 0:01 ` [musl] Potential bug in __res_msend_rc() wrt to union initialization Mike Cui
2024-03-19 13:18 ` Rich Felker
2024-03-19 15:04 ` Mike Cui
2024-03-19 15:42 ` Rich Felker
2024-03-19 15:55 ` Mike Cui
2024-03-19 16:08 ` Rich Felker
2024-03-19 16:39 ` Jₑₙₛ Gustedt
2024-03-19 20:47 ` Thorsten Glaser
2024-03-21 10:58 ` Jₑₙₛ Gustedt
2024-03-21 16:41 ` Thorsten Glaser [this message]
2024-03-19 21:04 ` NRK
2024-03-19 21:36 ` Rich Felker
2024-03-20 17:11 ` NRK
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.BSM.4.64L.2403211637580.19384@herc.mirbsd.org \
--to=tg@mirbsd.de \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).