From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 123992064A for ; Thu, 11 Apr 2024 20:44:08 +0200 (CEST) Received: (qmail 5448 invoked by uid 550); 11 Apr 2024 18:44:02 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 5410 invoked from network); 11 Apr 2024 18:44:02 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1712861034; x=1713465834; i=nullplan@gmx.net; bh=P5zovxeKtDU8KAV+2kWg6Dv4gE2E1B549c/zUhA8r0c=; h=X-UI-Sender-Class:Date:From:To:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=s9mbbpRn/A9BFPUe6sYAuNB8gq5sWPai4F7KmM8g7eHcfsAgiqwMKOaMa3QQRxzc eJo95xikuDvFBRfyO2NVaYWVVb6fhFJAMvzknELUuFUs4kZxTnobCufitPWzyQ4NE rXy/+9LwYubThji5cEZQnW/GqfT+APb+ZdJWt4RwfDFSJ0rRpzvDIZNRv0kiACBRv A7lUuDCGaejfLoDnwbO2+7sLxneZufW7+8L8sCbeOQTHFz6yNcHS7hAsVGQ7wb40r vlaty2PA9DCxWAXllVDBKigAIrK6Cb5f+Gq4KcnoyslseG8wyATDuQTivcQAHqjL3 fx7pf/ZcEjM89nYGuA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Date: Thu, 11 Apr 2024 20:43:52 +0200 From: Markus Wichmann To: musl@lists.openwall.com Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:Bm+/37KEmLdzq1hUUHNkh9EVQrLKyMKAdDvcwBGr4yX+lPAEaEU YAYnU1ENqAs6ucT95Moy8JCM7cw8rOtFLHETsz/jXK8OQxca2DTNE90hU5Gv87YXDZ0hiAf diiBnXcaBGROj6TglErpxknmJ0pF1M6JER5oaBnfogYnbcXu+IooB53ICi7vz2h8wkMywMR 8CWSdHmPSYtaoPU530dZA== UI-OutboundReport: notjunk:1;M01:P0:WpGS+5L9IA0=;CeLR5zJ89WsuQ74WPZKEjXfiMRL pXcmTeIKM/gPEu/ba6Iz5/5XSeOyqETzOFAmthxNkDuHPlGKJvQ975ok0+OUmd2SZTG8QC9DH s3OCZY4y5IKRaAhQGZNarzDu3iZPqQfz7VWTp+ccn/oEVtVS3y9iDxbtaxJ9QZgxZ2YZ4BmLs 9p2mSAvyHJl3NoPqRH+X/7+4fo2Z0ZVQpkDTJC/8aAWsAGOc50efWeL6WnDg7ML/+Jv5QGEE9 H81Sv3Y057IB/Fie/Dbl2eZpQJt3QrXpfE1tT5rhKimu5ovqrJ3gB+9S140n2/BXrThLGOztM iuTZiOaZ3TkJUk0UBLuKAW268duGbS4HXKLFs5O+SGXlGiP8dpBcK4dpOZenOBuUTCAqVBfKM KkERgv18D70dGIbu4Dn9E7EyRkoQhBLLHQLzXfCBoA2bAbfAUaV0iHH08Z/65MnBtWxSfLZ4u /tcHLoJeE4PN8IvROt5ghwv8V6h5VIYIJTBwvukRA/E+SbozjEwUDotC0rR96Hgju1JwGoN/2 hRrmKT1AN9m/HW5+usw3lncBGenWjq/V8fqDs9rgZSpdcBQoA5FWVRg1fxcxbVItJ0gBKhCRu /SA8XdS22XNpHAveP51JuOnzCt1eRCtPnADF0XXyvbInrfHhM6a/anFqGNAdLCLMQjK6rceDZ ojigmWhkbS+PgGEUrC0qf97sL2PR0aD09NdCSF1zGvUtZ8j9elvBGJwgVTSaB/J5u9uA5LG1/ blCyyipk5e+yboE1BkKwHJ82KItbxUYADMFKfoiDQPrT1P2jJpiXX5oQePCrQNZQoFZ8k1aJg WcrBGKtBPRR7x3/DaxFkDbT247vUz4rU6yvbb/tcY2Akw= Subject: Re: [musl] Re: [PATCH] iconv: Add check null-check for scd pointer Am Thu, Apr 11, 2024 at 08:56:56PM +0300 schrieb Maks Mishin: > Rich, I'm sorry, but it's now always possible to test a particular function. > Can you tell me how you are testing the library? > This will help me make more meaningful patches. You write tests and link them against musl, and then execute them. The most comprehensive test suite is probably libc-test (http://nsz.repo.hu/git/?p=libc-test), but for this it would have been overkill. In case of something like iconv(), I would probably create a utility similar to iconv(1), link it against musl, then write a shell script with a few test cases. If you get the expected output, everything is fine. If not, you broke something. It would be harder to test something like if_nameindex(), which has a different right answer on every given machine. But iconv() does not depend on anything in the system. You just give it input charset, output charset, and an input, and it generates the same output every time, or else it is broken. Ciao, Markus