From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 22097 invoked from network); 31 Aug 2020 06:55:50 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 31 Aug 2020 06:55:50 -0000 Received: (qmail 13874 invoked by uid 550); 31 Aug 2020 06:55:49 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 13853 invoked from network); 31 Aug 2020 06:55:48 -0000 Date: Mon, 31 Aug 2020 09:55:37 +0300 (MSK) From: Alexander Monakov To: musl@lists.openwall.com cc: Theodore Dubois In-Reply-To: <20200831010710.GH3265@brightrain.aerifal.cx> Message-ID: References: <3C00D395-838B-4DB0-99FC-3947F1BCF054@icloud.com> <20200831010710.GH3265@brightrain.aerifal.cx> User-Agent: Alpine 2.20.13 (LNX 116 2015-12-14) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [musl] i386 __set_thread_area will crash if the syscall fails On Sun, 30 Aug 2020, Rich Felker wrote: > > Tangentially, I'm not sure why this file has so many hardcoded magic > > numbers and no comments to explain what they are. > > Really it shouldn't even be external asm anymore. I'm trying to move > as much external asm as possible to inline asm written in C, and this > could be written entirely with __syscall() after #define > SYSCALL_NO_TLS (recently added) and all the structures setup > explicitly in C. I'll take a stab at doing that after fixing the bug. I also would like an answer to a question about utter lack of comments that your response did not directly address. This is an issue in specialized asm implementations of math functions too, for instance. Alexander