From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9517 invoked from network); 16 Sep 2020 05:06:10 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 16 Sep 2020 05:06:10 -0000 Received: (qmail 32733 invoked by uid 550); 16 Sep 2020 05:06:01 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 32715 invoked from network); 16 Sep 2020 05:06:01 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=landley-net.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Aktf9C41ce9d7DHO1lUxWG3XopbQPeUuPYeX0urT4Kc=; b=Fl9NemxCTxG2w5+Jj3fpcTu55fUnTFfAPgnl07BuoW9397jq7agS9PdxatO741tP+Y qZIzb6KzQfgPsfTfBkX2gNhEFKAyvz9Yi+XW5cGs/tkBZFsgMCRPQWOxlZPpbE7CsJk4 S2zNNxwZgymKrcKcYgOEfF1nH9zbyM1I5LYeh/9pGdKYGmayiVt2wF4fM4/To4ouQaAa HzVQSu4kLkMXyjCfF8iTXTRQyWjnJwZkr3mZoGzKxq6DRsDi6j2QkKnn4E+o50RkkBR6 CvlVUS/A9w7cJKuxUMVccz27vRXtyYWjrR9pp0iilvj3laugzq47BPUyOAurWn0cCYn+ 2csQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Aktf9C41ce9d7DHO1lUxWG3XopbQPeUuPYeX0urT4Kc=; b=PnSsvmqfdCZFlLWoPHspnLTIaxg7Wnou+oKLMovzvbpupOE4Y75Ab8WlZhf75EZBBH kR+0ExZuuhuRNplvuEwBIju6tU6Mv2LoUVBWqGls/ENs+bXChAgjLPMr4aSzf5RAJ6+8 y3laCQQvXrRe54N4VoEVAi/5tS0as1hi6ExSIjOc78Bk8Q7I1dhv1vIyPBq3oVLpxoHe D22LAHjBEHtX92ZGkeRE0+SVg6KCjhtLt4tLjJWEpJvQLJX7mBDsJPg62m4Hju7/ewlQ F3pMcCUFX5CgiTz0gJf4e5sK2iOC/OjN2Htyunw0iGxOTqJXXFkApRuWMEdlWXQ+cYlz x+Zg== X-Gm-Message-State: AOAM532dd0+Ja2UCL/gbQhSO5AOsAxOfbndh67NEOsqxuDoVQ8YlZcGg lG7ZmJ0g0N7QeqRjcDt1Up10kT1f1qOrroX2 X-Google-Smtp-Source: ABdhPJwxWzo8BrCEuuKtJG/JKtm9slZYdu/NfV7etD+Ysq/1XPx6ktRLgjXGuOFPwOBYqiee/PBd0Q== X-Received: by 2002:a54:488c:: with SMTP id r12mr2056864oic.60.1600232748927; Tue, 15 Sep 2020 22:05:48 -0700 (PDT) To: musl@lists.openwall.com References: <20200904195251.GA2139@voyager> <20200905034153.GI3265@brightrain.aerifal.cx> <20200905064419.GB2139@voyager> From: Rob Landley Message-ID: Date: Wed, 16 Sep 2020 00:15:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200905064419.GB2139@voyager> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [musl] Bug in mmap_fixed() On 9/5/20 1:44 AM, Markus Wichmann wrote: > On Fri, Sep 04, 2020 at 11:41:54PM -0400, Rich Felker wrote: >> When I saw your report, I thought this code all ran with signals >> blocked, and actually had to check to see that this isn't the case. > > In that case, making an exception for EINTR would be even weirder. > >> The code hsould be fixed, and EINTR handling should probably be left >> in-place, just without the wrong pointer-advance logic. >> > > See attached. Untested, obviously, since I lack a Super-H processor and > an NFS server, Coldfire is also nommu and musl has had m68k support for years, is there no coldfire target? (That's been supported by qemu longer than proper m68k.) Rob P.S. This patches out the broken fork() on nommu sh2, and fixes the sh2 native toolchain build: https://github.com/landley/toybox/blob/master/scripts/mcm-buildall.sh#L130