zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <opk@zsh.org>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: Clinton Bunch <cdb_zsh@zentaur.org>, zsh-workers@zsh.org
Subject: Re: current git Fails to compile on Solaris 11 x86
Date: Wed, 20 Mar 2024 23:26:38 +0100	[thread overview]
Message-ID: <15976-1710973599.000679@Gv72.cS7i.MXME> (raw)
In-Reply-To: <615589318.5857173.1710951314600@mail.virginmedia.com>

Peter Stephenson wrote:
> The wrapper function just fits a generic form, so should stay void.
> It's as simple as it looks.  (I guess the line numbers were out in the
> code I was looking at so I misidentified what it was complaining about.)

Yes sorry, that fix is right. I still have my git branch and, looking
at the steps, I mistakenly copied the same form from the get*
functions when factoring out the common code for the
.zle.esc and .zle.sgr parameters.

Also the following fix is needed for this case:
  typeset -A .zle.hlgroups
  zmodload -i zsh/hlgroup
  : ${.zle.hlgroups[select]}
  export GREP_COLOR=${.zle.sgr[select]}

Oliver

diff --git a/Src/Modules/hlgroup.c b/Src/Modules/hlgroup.c
index f20f2c1f9..082762623 100644
--- a/Src/Modules/hlgroup.c
+++ b/Src/Modules/hlgroup.c
@@ -91,7 +91,8 @@ getgroup(const char *name, int sgr)
     if (!(v = getvalue(&vbuf, &var, 0)) ||
 	     PM_TYPE(v->pm->node.flags) != PM_HASHED ||
 	     !(hlg = v->pm->gsu.h->getfn(v->pm)) ||
-	     !(hn = gethashnode2(hlg, name)))
+	     !(hn = gethashnode2(hlg, name)) ||
+	     (((Param) hn)->node.flags & PM_UNSET))
     {
 	pm->u.str = dupstring("");
 	pm->node.flags |= PM_UNSET;


      reply	other threads:[~2024-03-20 22:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20  4:41 Clinton Bunch
2024-03-20  9:30 ` Peter Stephenson
2024-03-20 10:19   ` Peter Stephenson
2024-03-20 12:21     ` Clinton Bunch
2024-03-20 14:54       ` Bart Schaefer
2024-03-20 15:05         ` Clinton Bunch
2024-03-20 16:15           ` Peter Stephenson
2024-03-20 22:26             ` Oliver Kiddle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15976-1710973599.000679@Gv72.cS7i.MXME \
    --to=opk@zsh.org \
    --cc=cdb_zsh@zentaur.org \
    --cc=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).