From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 6a69d2ee for ; Fri, 23 Aug 2019 04:49:19 +0000 (UTC) Received: (qmail 5129 invoked by alias); 23 Aug 2019 04:49:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44700 Received: (qmail 24284 invoked by uid 1010); 23 Aug 2019 04:49:14 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25545. spamassassin: 3.4.2. Clear:RC:0(66.111.4.26):SA:0(-2.6/5.0):. Processed in 0.745338 secs); 23 Aug 2019 04:49:14 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm1; bh=lShMDuWDgCPAUjuzxbn4X+l1eKlz4Q+wvhQUFRSZ Za4=; b=LV0UWiS9mfthITn20crLoXhCAnHK+kowYPpKDth857QYOvdUCZKwfKb0 HDlAJ9hKL3IaeMY5BbktG5gilnoJ1IayIczRniqboUn9NFoAYT/33i9iCD6GgFzZ OAYPihQFMLly6PmxwEwH+cCiSlGS0HvX5gjrEv6RjMkM/LbeGaW3Q3B9EIFZuHVw YivuSH3L1i0QdeOZKK2rbC4xvibfscl45JRGl2DfZJYd8RX1vxQwrH6dcGz2omVk 0NDNOCeBQ2BFgBW0Ps9EYS2eQLjQdnAyGAy+gIgvN7yAW34LfdVomdPAADF54TXJ St7EapPyaaHnVtuoQFmt0XlNnKetNw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=lShMDuWDgCPAUjuzxbn4X+l1eKlz4Q+wvhQUFRSZZ a4=; b=khUzRIdlvpjygMTzKV/gW3dkOIgur9eJSCe2pkDlntXDgQUZXySH0nPI+ yye0kTLr41stRS+TMET820zROkob9ZbKoGH+jPPF5S4sNf9pNOwMp4FCne2v8B5u jqwPN8gmpHD1vrUPAIGwsmNOn0XjqawPsjVl5C/Gdjm4W9YXJmDSGiPtZBklI72o lRqlw/jaGg/BsNBPH8eSq22RdNRUUAI9CbexKQYA7fimyJ2izKGY5yfcdJj5W2wz lixAlMTE4fVjRp7eFaYLdz+9c+mJAz5wZJN8VQhkFuNrnwvSlBlffh9k1yaM1d6M jhLfqq6Yk3OU0QwwtTm3Xnn1OM/hg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudegjedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjfgesth ektddttderudenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecukfhppeejledrudejiedrkedurdefgeenuc frrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgr mhgvnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Date: Fri, 23 Aug 2019 04:48:37 +0000 From: Daniel Shahaf To: Daniel Hahler Cc: zsh-workers@zsh.org Subject: Re: [PATCH] _make: target: handle "make -C dir" Message-ID: <20190823044837.76ulv2oyrtr7xrzj@tarpaulin.shahaf.local2> References: <20190822063753.25557-1-genml+zsh-workers@thequod.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190822063753.25557-1-genml+zsh-workers@thequod.de> User-Agent: NeoMutt/20170113 (1.7.2) Daniel Hahler wrote on Thu, Aug 22, 2019 at 08:37:53 +0200: > `$basedir` defaults to `$PWD`, so it is ok to pass it always (I assume). If the current working directory has been deleted, «$PWD» and «./» may refer to different directories. > - _make-parseMakefile < <(_call_program targets "$words[1]" -nsp --no-print-directory -f "$file" .PHONY 2> /dev/null) > + _make-parseMakefile < <(_call_program targets "$words[1]" -C $basedir -nsp --no-print-directory -f "$file" .PHONY 2> /dev/null) Should be «${(q)basedir}», I presume? Preexisting issue: the other two parameter expansions should probably use the «${(q)}» syntax too. Preexisting issue: the last line of _make-findBasedir should use «print -r», or better yet, assign to REPLY.