From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,RDNS_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: (qmail 21090 invoked from network); 24 Mar 2020 02:44:04 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from unknown (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTP; 24 Mar 2020 02:44:04 -0000 Received: (qmail 2464 invoked by alias); 24 Mar 2020 02:43:58 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45612 Received: (qmail 20040 invoked by uid 1010); 24 Mar 2020 02:43:58 -0000 X-Qmail-Scanner-Diagnostics: from wout4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25758. spamassassin: 3.4.2. Clear:RC:0(64.147.123.20):SA:0(-2.6/5.0):. Processed in 0.755679 secs); 24 Mar 2020 02:43:58 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudegledggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkjghfofggtgfgsehtqh dttdertdejnecuhfhrohhmpeffrghnihgvlhcuufhhrghhrghfuceougdrshesuggrnhhi vghlrdhshhgrhhgrfhdrnhgrmhgvqeenucfkphepjeelrddukedurdeluddrhedtnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepugdrshesuggr nhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Date: Tue, 24 Mar 2020 02:43:20 +0000 From: Daniel Shahaf To: Jun T Cc: zsh-workers@zsh.org Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin Message-ID: <20200324024320.12bae9e9@tarpaulin.shahaf.local2> In-Reply-To: References: <82F8CDE0-C95C-4D31-ABFC-EBB3C97799F3@kba.biglobe.ne.jp> <1B509B1C-A670-482F-9D88-2145E15D03A1@kba.biglobe.ne.jp> <20200109131553.hqetnd45sc43z6xb@tarpaulin.shahaf.local2> <087AE8B9-35B0-4258-9626-AACA85471A07@kba.biglobe.ne.jp> <20200111201549.GA1264@tarpaulin.shahaf.local2> <3340070A-53DD-40F0-8363-A8C7D84702D3@kba.biglobe.ne.jp> <374cecf6-45d5-4688-861f-cc52017dbcea@www.fastmail.com> <321F9465-ABF9-465D-9242-7EF9A0EDDBED@kba.biglobe.ne.jp> <20200320191846.3a4f5682@tarpaulin.shahaf.local2> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jun T wrote on Tue, 24 Mar 2020 10:33 +0900: > > 2020/03/23 14:41, I wrote: > >=20 > > Personally I feel only adding a test (B12limit.zsh) is enough for now, = but > > have no objection to adding a runtime check in rlimits.c. =20 >=20 > If I add the runtime check, and if there is a duplicated option letter, > I get the error message 'duplicate ulimit option letter' every time > I start zsh. This may be quite annoying for ordinary users. That message is printed by the DPUTS1() macro. That macro expands to nothing unless the =C2=ABDEBUG=C2=BB preprocessor symbol is defined, which happens if one runs configure with --enable-zsh-debug. Ordinary users shouldn't see that. > B12limit.ztst (limit| grep UNKNOWN || print OK) fails due to the error > message; I think it's OK. But V01zmodload.ztst also fails due to the > message, and other tests would fail if they use the rlimits module. >=20 Only in --enable-zsh-debug mode, and the fix is trivial: edit known_resources and change one of the two colliding resources' letter to 'N'. Does this address your concerns, or would you prefer something more? We could even remove the DPUTS1() call entirely. > So I think just adding a test for duplicated option letter is enough. > If someone add a new resource then it is their responsibility to > confirm that all the tests pass. I think ordinary users need not see > the error message. They won't, unless they configure with --enable-zsh-debug. Cheers, Daniel