From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Cedric Ware <cedric.ware__bml@normalesup.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Enable sub-second timeout in zsystem flock
Date: Wed, 15 Apr 2020 01:15:30 +0000 [thread overview]
Message-ID: <20200415011530.2b8f3ed3@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20200414202100.x7fxbf3liwbyclpe@phare.normalesup.org>
Cedric Ware wrote on Tue, 14 Apr 2020 22:21 +0200:
> Hopefully this patch can now be integrated, unless there are new
> issues?
The issues I've raised before have all been addressed (other than the
new nits below); however, I haven't done a line-by-line review.
dana, would you happen to have time to review the Cedric's latest
revision (workers/45690)? No problem if not; just asking since you
reviewed earlier revisions.
Cedric Ware wrote on Mon, 13 Apr 2020 23:34 +0200:
> +++ b/Doc/Zsh/mod_system.yo
> @@ -196,9 +196,16 @@ item(tt(zsystem flock -u) var(fd_expr))(
> +(Note: var(timeout) must be less than 2^30-1 seconds (about 34 years);
> +and var(interval) must be less than 0.999 * LONG_MAX microseconds
> +(only about 35 minutes on 32-bit systems).)
The semicolon feels out of place. (Might be just me, though.)
> +++ b/Test/V14system.ztst
> @@ -0,0 +1,150 @@
> +# Test zsh/system module
> +
> +%prep
> +
> + if zmodload -s zsh/system && zmodload -s zsh/zselect; then
> + tst_dir=V13.tmp
s/V13/V14/
>
Cheers,
Daniel
next prev parent reply other threads:[~2020-04-15 1:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 20:35 Cedric Ware
2019-07-29 22:25 ` Bart Schaefer
2020-01-04 18:47 ` Cedric Ware
2020-01-05 18:42 ` dana
2020-01-05 21:49 ` dana
2020-01-06 17:30 ` Cedric Ware
2020-01-06 17:36 ` Peter Stephenson
2020-01-07 3:48 ` dana
2020-01-11 15:41 ` Cedric Ware
2020-01-11 19:36 ` dana
2020-01-12 4:25 ` dana
2020-03-08 18:39 ` Cedric Ware
2020-03-12 18:46 ` dana
2020-03-12 19:13 ` dana
2020-03-14 21:04 ` Cedric Ware
2020-03-15 0:50 ` Daniel Shahaf
2020-03-15 1:04 ` dana
2020-03-15 16:03 ` Cedric Ware
2020-03-15 16:54 ` Daniel Shahaf
2020-03-15 17:35 ` Peter Stephenson
2020-03-15 18:36 ` Cedric Ware
2020-03-15 19:13 ` Daniel Shahaf
2020-04-13 21:34 ` Cedric Ware
2020-04-14 11:47 ` Daniel Shahaf
2020-04-14 20:21 ` Cedric Ware
2020-04-15 1:15 ` Daniel Shahaf [this message]
2020-04-15 2:05 ` dana
2020-04-16 4:24 ` Daniel Shahaf
2020-04-18 16:32 ` Cedric Ware
2020-04-20 17:28 ` dana
2020-04-20 22:17 ` Cedric Ware
2020-03-15 1:04 ` Daniel Shahaf
2020-03-13 14:26 ` dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415011530.2b8f3ed3@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=cedric.ware__bml@normalesup.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).