From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [RFC][PATCH] Add change-directory() widget function
Date: Tue, 20 Apr 2021 22:14:29 +0000 [thread overview]
Message-ID: <20210420221429.GF1035@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <4D587C0C-EB5F-4A58-A0AE-D45E43F432CD@gmail.com>
Marlon Richert wrote on Tue, Apr 20, 2021 at 23:13:35 +0300:
> +++ b/Functions/Zle/change-directory
> @@ -0,0 +1,29 @@
> +zle .push-line-or-edit
> +case $WIDGET in
> + *-upward )
> + if [[ -o autocd ]]; then
Why is the «if» codepath necessary?
> + BUFFER='..'
> + else
> + BUFFER='cd ..'
s/cd/builtin cd/?
Should the -q option be passed to «cd»?
Should any of the words be quoted to protect against global aliases?
Does the existence of CHASE_DOTS / CHASE_LINKS raise any concerns?
Should this be implemented in C so it can call chdir(2) directly without
gymnastics?
Regarding your first post in the thread, lines weren't wrapped,
which made it hard to read.
Daniel
> + fi
> + ;;
> + *-backward )
> + if [[ -o pushdminus ]]; then
> + BUFFER='pushd -1'
> + else
> + BUFFER='pushd +1'
> + fi
> + ;;
> + *-forward )
> + if [[ -o pushdminus ]]; then
> + BUFFER='pushd +0'
> + else
> + BUFFER='pushd -0'
> + fi
> + ;;
> + * )
> + print -u2 'change-directory: widget name should end in -(up|back|for)ward'
> + return 1
> + ;;
> +esac
> +zle .accept-line
> --
> 2.31.1
>
>
>
next prev parent reply other threads:[~2021-04-20 22:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 13:36 Marlon Richert
2021-04-20 19:43 ` Bart Schaefer
2021-04-20 20:13 ` Marlon Richert
2021-04-20 21:32 ` Bart Schaefer
2021-04-21 3:46 ` Bart Schaefer
2021-04-21 11:37 ` [PATCH] Add execute-command() widget function (was Re: [RFC][PATCH] Add change-directory() widget function) Marlon Richert
2021-04-21 20:40 ` Bart Schaefer
2021-04-21 21:27 ` Daniel Shahaf
2021-04-21 21:58 ` Bart Schaefer
2021-04-22 10:55 ` Marlon Richert
2021-04-22 20:25 ` Daniel Shahaf
2021-04-22 23:27 ` Bart Schaefer
2021-04-24 20:06 ` Marlon Richert
2021-04-24 21:49 ` Bart Schaefer
2021-04-24 21:58 ` Bart Schaefer
2021-04-26 18:08 ` Marlon Richert
2021-04-26 21:39 ` Bart Schaefer
2021-04-27 10:46 ` Marlon Richert
2021-04-27 19:27 ` Bart Schaefer
2021-04-30 19:16 ` Marlon Richert
2021-04-30 20:25 ` Bart Schaefer
2021-05-01 13:30 ` Marlon Richert
2021-05-31 17:55 ` Marlon Richert
2021-04-25 17:02 ` Hard-wrapping emails (Was: [PATCH] Add execute-command() widget function (was Re: [RFC][PATCH] Add change-directory() widget function)) Lawrence Velázquez
2021-04-20 21:57 ` [RFC][PATCH] Add change-directory() widget function Daniel Shahaf
2021-04-20 22:14 ` Daniel Shahaf [this message]
2021-04-21 0:09 ` Bart Schaefer
2021-04-21 3:18 ` Bart Schaefer
2021-04-21 20:11 ` Daniel Shahaf
2021-04-21 20:29 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420221429.GF1035@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).