From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id EF49B24B33 for ; Mon, 4 Mar 2024 20:34:31 +0100 (CET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1709580871; b=hhqtIvFYVhxn50NFzzY8oolu3Q/raw/vXleuRx7kfsU8jXzbNhI0N1LiFxqt7I9h1MPdUaMcZd Q1COzXZLYLB/uywYVsXaKnU6mqGjs6ouiDv8/hqSCSGeJIRY768EdxJ3cInB+8KlMf9JJiagG5 2XruCD4oBphAHY7McLfeWoQ7VSNs7SS6H+eus1vUi8v3E3Tlgs3+9GMbhSxvscPIvk6Jj05ewz 7ELUvbT2NKKjWuvFaJfmvg4oD6fgwwfZgPIMAmAQS+yb2Iy2uVBYnfbCL9w6XDyQcbBIFQDFBX 0deAU9O+aiBgBcWWT7udxyuFIU+uIdqtkPXRGwtPfcSRAA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (relay5-d.mail.gandi.net) smtp.remote-ip=217.70.183.197; dmarc=none header.from=chazelas.org; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1709580871; bh=cXvAAN3XRSJP8uiY1xeXQ/23DgqPMZevKWe3BqEyGss=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature; b=b1gxOAtmsfYlE95TDHlZ3pi54BlgOId3DF4BKcVCbpJ+tjZGgp1qcpTpTfi38b1RMDJ2t9RoZZ tu5W37TOkQcM/zWu0SBSYgn8LqVMIJ87PNU9Y3a75vB9UPER9GQIrfiVFmfF+wvJIghSVWArq/ MjXlJoIIXss1aBe1SLMMuBQaEZG1gEuwp+wZP7BcfQ0lO3qpjiQnEpYwiBRZ35cYhGOpcWGoDR ykRRWEQtdmWw5iwJGr3klUPin/k6HZljsVhwgz+/xog6qMG2N3nmdxb0S71gSn5tBVlrMMr/bB r0IXBg2KTmKJxGB6W4rgtR1X/U96upsjawnQldkrqxQ92Q==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=OjxcY9ODsRSDMKoRLpiySbYZTcwsltmmNzVfb+qSTSw=; b=nxUXBawFJARNtXmV9lGuQ9bdwd eeTTYEcIOTw9CrJDmYimCp1vMAz3Wvc3KnQJI/1bHm3cm9tqNIkuaL+kr6fd713pFYtsYr0Kivc7q r3JQQ2/ZQwb8RMo24SMyL/X/92hzkVN6pB47kV52BbYeiOFSCeHCgy5X5iJ9o6Q4kbfnoip5MjCR/ 3Q2YqpFplut55drG3sPyY+BvblfOrxB8hB1IgNYXlDrAFgkFDx8seG07UqliD90H4+AVMlXhZPrBc N2vfb5+5CsnJPTfmC0kNnD3eGy1WD3nwZZH915KhEz5tDJa78tpj4LAfbPOR02knocZ+iCZkOaMEL ftbwpJPg==; Received: by zero.zsh.org with local id 1rhE51-000H9e-84; Mon, 04 Mar 2024 19:34:31 +0000 Authentication-Results: zsh.org; iprev=pass (relay5-d.mail.gandi.net) smtp.remote-ip=217.70.183.197; dmarc=none header.from=chazelas.org; arc=none Received: from relay5-d.mail.gandi.net ([217.70.183.197]:50135) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1rhE4i-000GrZ-VE; Mon, 04 Mar 2024 19:34:15 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 782951C0002; Mon, 4 Mar 2024 19:34:11 +0000 (UTC) Date: Mon, 4 Mar 2024 19:34:09 +0000 From: Stephane Chazelas To: Bart Schaefer Cc: Zsh hackers list Subject: Re: [PATCH] Fix crash on unset-through-nameref Message-ID: <20240304193409.lv725ah6eifiazzx@chazelas.org> Mail-Followup-To: Bart Schaefer , Zsh hackers list References: <20240304062914.kn6wquvgog3lefom@chazelas.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-GND-Sasl: stephane@chazelas.org X-Seq: 52667 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: 2024-03-04 00:39:30 -0800, Bart Schaefer: > On Sun, Mar 3, 2024 at 10:29 PM Stephane Chazelas wrote: > > > > That shows an unset through a nameref in a different scope > > doesn't do a full unset > > Try removing this line from the patch: > > + pm->node.flags |= PM_DECLARED; > > If that works, it'll also require updating the test. That helps a bit but: $ ./Src/zsh -c 'myunset() { typeset -n v=$1; unset v; }; export x=1; myunset x; typeset -p x; x=2; typeset -p x' export x=2 It still retained its export attribute. -- Stephane