From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id 99A7B25670 for ; Mon, 4 Mar 2024 20:37:01 +0100 (CET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1709581021; b=EEUtYGPR9C1JE6VZd0YDVhDrTXzqLfnOSYke3BKex86G/Ez/TyfWUYxZg9SdYn7YaVWpzi+e7F H61mvhJ+c1wLdPre3ijUmUo7OnjA/Esm+cJcwr66oojuCFAS5eHGv+dsHKPpkXr45OnLyu/iK4 SZ2FY8k1EQIexqTcTR5ckYLrb8SdO0D6d5eaD3+TdlAQWppeQXfmhhkLbIZFuM7hU1ESnKaA1S u+nN5dx0BBl55rH+qaB6gp6L6kvbMQ9ZHC8n6+ktKM6Mzz/qyfNkr6QksPLoNDbJvNbrr5w2jw te8pt6WVkbsD2OpaGegi5R4JWqeTrKuUpEte0r2zG/XNjQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (relay1-d.mail.gandi.net) smtp.remote-ip=217.70.183.193; dmarc=none header.from=chazelas.org; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1709581021; bh=bKdQYOoCp1FvmitvjSytTS5sovcWc3VatVxUbOcu1FI=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:To:From:Date:DKIM-Signature; b=oQHViX6EDjZI1bnJx7om4gM0zB0c9TGXbeS4ejGo4OTNJtOzNHkQnjqT3uCxDX44iIyKpxSQ1S YwpXP64xaHH2a3KY68F+3+jmOJyO3n02i1AXlokIip42PD7uLdgW+WNIoynuShBPTIvey6rhtF fxhnkgQVocLTNbzcziC7ktp3MqRvrLk/jhvx9DVYluAXyZArMYmCzvqCXYGkKH32y8fj2InjdO RK9vZ/l7XI1e6YetwHEUk0Bpa7K83utTL0Z7uBJH9UbmdRKHo8v5mjfJbuUHtZE/cqXFA1PlKB VtuL0QwQ4f+Xgs9BC8phkAtEhQEI3xjOwy9ck3aBxn0qgA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=917IqVYSYFAWORvXt1IxZqvSsft3BHnqLxylxu8IAxE=; b=htd+S6kfEOqqMTpU3zdzq4tgI8 flALMbr7F3oGkOFv4uMXrG+A+tXD+lXfTADTB/PgdS/6bo/hXUrZ2NIgBCQ1zSXZeuxrBr0B1i98T 9zaJtI92YD1tKrulCR8bMXqGjTmSvcMDBFcSnUI7JCtNbr8NxJeSC7ItEiBzIjNIukSogXnbN8Mta f9gDYm4/8RS3byIZkVAI8BNxA8D5osPZ45bcg52qPSt3BuBnIGTp+zScfLzAZc5zPC3VQXyDpr23x 6eT1BUSnSlZaYfm1LrebWTNB7/97Jwen8pNn/1i+gSdM+DbG7FbbnUJseAPZ4YQsd/XJ0bu8mwVHs WCC96KPA==; Received: by zero.zsh.org with local id 1rhE7R-000HrT-DY; Mon, 04 Mar 2024 19:37:01 +0000 Authentication-Results: zsh.org; iprev=pass (relay1-d.mail.gandi.net) smtp.remote-ip=217.70.183.193; dmarc=none header.from=chazelas.org; arc=none Received: from relay1-d.mail.gandi.net ([217.70.183.193]:44247) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1rhE7B-000HWp-VW; Mon, 04 Mar 2024 19:36:46 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 21585240003; Mon, 4 Mar 2024 19:36:44 +0000 (UTC) Date: Mon, 4 Mar 2024 19:36:41 +0000 From: Stephane Chazelas To: Bart Schaefer , Zsh hackers list Subject: Re: [PATCH] Fix crash on unset-through-nameref Message-ID: <20240304193641.gdjs7girbrvzxq6j@chazelas.org> Mail-Followup-To: Bart Schaefer , Zsh hackers list References: <20240304062914.kn6wquvgog3lefom@chazelas.org> <20240304193409.lv725ah6eifiazzx@chazelas.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240304193409.lv725ah6eifiazzx@chazelas.org> X-GND-Sasl: stephane@chazelas.org X-Seq: 52668 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: 2024-03-04 19:34:09 +0000, Stephane Chazelas: > 2024-03-04 00:39:30 -0800, Bart Schaefer: > > On Sun, Mar 3, 2024 at 10:29 PM Stephane Chazelas wrote: > > > > > > That shows an unset through a nameref in a different scope > > > doesn't do a full unset > > > > Try removing this line from the patch: > > > > + pm->node.flags |= PM_DECLARED; > > > > If that works, it'll also require updating the test. > > That helps a bit but: > > $ ./Src/zsh -c 'myunset() { typeset -n v=$1; unset v; }; export x=1; myunset x; typeset -p x; x=2; typeset -p x' > export x=2 > > It still retained its export attribute. [...] The other one is now wrong in a different way: $ ./Src/zsh -c 'f() { typeset -n v=$1; unset v; typeset -p w; v=(a b); }; w=1; f w; typeset -p w' typeset -a w=( a b ) $ ./Src/zsh -c 'f() { typeset -n v=$1; unset v; typeset -p w; v=(a b); }; v=1; w=1; f w; typeset -p w' $ -- Stephane