From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id 25174212F8 for ; Sat, 9 Mar 2024 11:06:22 +0100 (CET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1709978782; b=Gtn+9whCjxdPcV5LRvj0oRxkRsPvpHdt5o/8RVNAAkr03ykn26fPSea3GO8RFo3ulerLNNHvW4 9khLRB4kLlmzMWUPRNQanndN0KsyuLnaQY/pOlp/jX2NJygtt4ON1ikzeQa5XXmtw58bC1910k CRzjXXeNmTba7lavEFytCMTZnwGs9yZAKJHtP/KpTU/teuGXYPnZ0jXbpkevkFM4nO7j2BdeBz ZMB2CZskvgij/r+oA93zo2Cpso5KLUsOqhnXddbatP89xUX8suI38qVx4wqVQJ+49Y5W47T8Ww 9sJpV11ovWLGQ5YrKaVfbucJcEXrHZJDIpE/0hUawaoVMQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (relay9-d.mail.gandi.net) smtp.remote-ip=217.70.183.199; dmarc=none header.from=chazelas.org; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1709978782; bh=T7KEYHRWq2e4lc9AbegeTMku4rMnbrat9/ilA6vp5CM=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:MIME-Version:Message-ID:Subject:To:From:Date: DKIM-Signature; b=MR37WdhbzakNXUv/EaBmXDK8eIcBvdwek33jtc+5VsPS0+9Rzj3KkLkojE/yh896MW32oHMoKT WZ4OcdPd6KLMUbAzFGbG+DH49peQEstY7JKC/zDibjid9mO+d1/T4OC+RWA/B3iVFc1GKTAptl vjFxaXeFOv7jGRDLHc/6X1wv84H/Y/odi04CAiKnVBJicAsY+MAL9PmsMYWq38OGs1MCKzbKqc ba4CCVaWs8n9twC2XHeouckIXBNk1NU7stpeCYphiMEGbEzUtBHjlIt+7x6095kbt6aoJPCfDY anHc1SVv89atRoO9JLDVNWQN4VRzUnLDQnA8fyspUYQOmA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:MIME-Version:Message-ID: Subject:To:From:Date:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References; bh=6tc2C8CwytV06EkDHnAbiOjwjmDpY9Syi0VrobjdWLY=; b=mbcE6U8TTsCCB5NPpBpmRMl1qf r14gxFRi190hCJe81mQNDUJmQzu0jIPEehwB7b9xrwJw5YNH80ykW3SIIogO8etU4pGwNHywUauwg 5MT9V5tTkLrdMeaGxUa1NEebw67ABzNIRVUw2yXEOv5+mRqqENXrirti7ZWLkZVv3conBJ8+4r3Nv tUcaax1USqjfishPae15kZmrww438Wbndvf2IUnS/9CogtPmRec1gCu8xQXmEFF+CBVvL50zwprao uEy39YNAR6YDy/597FmFg1KtiAjCdPJCGZlm+XHWohAx8LWeYdS7MPv0lXpPkPQ70Kg2NoQSkJAcX XtBQCCUw==; Received: by zero.zsh.org with local id 1ritaw-000ITm-Cz; Sat, 09 Mar 2024 10:06:22 +0000 Authentication-Results: zsh.org; iprev=pass (relay9-d.mail.gandi.net) smtp.remote-ip=217.70.183.199; dmarc=none header.from=chazelas.org; arc=none Received: from relay9-d.mail.gandi.net ([217.70.183.199]:43743) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1ritai-000I9p-W7; Sat, 09 Mar 2024 10:06:09 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 78E5FFF805 for ; Sat, 9 Mar 2024 10:06:08 +0000 (UTC) Date: Sat, 9 Mar 2024 10:06:07 +0000 From: Stephane Chazelas To: Zsh hackers list Subject: [PATCH] improve pcre error message Message-ID: <20240309100607.avfimrgvlaleipjf@chazelas.org> Mail-Followup-To: Zsh hackers list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Sasl: stephane@chazelas.org X-Seq: 52721 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: $ pcre_compile . $ pcre_match $'\xff' pcre_match: error in pcre matching for /\M-^?/: UTF-8 error: illegal byte (0xfe or 0xff) $ pcre_match $'\x87' pcre_match: error in pcre matching for /*/: UTF-8 error: isolated byte with 0x80 bit set Those /.../ are misleading as it's the subject we're talking of here, not the regexp and there's a missing metafy (or unwanted unmetafy) for the argument passed to zwarn (another of those moles that need to be whacked). The patch below changes it to: $ pcre_match $'\xff' pcre_match: error in pcre matching for \M-^?: UTF-8 error: illegal byte (0xfe or 0xff) $ pcre_match $'\x87' pcre_match: error in pcre matching for \M-^G: UTF-8 error: isolated byte with 0x80 bit set diff --git a/Src/Modules/pcre.c b/Src/Modules/pcre.c index a49d1a307..67157cc01 100644 --- a/Src/Modules/pcre.c +++ b/Src/Modules/pcre.c @@ -405,7 +405,7 @@ bin_pcre_match(char *nam, char **args, Options ops, UNUSED(int func)) else { PCRE2_UCHAR buffer[256]; pcre2_get_error_message(ret, buffer, sizeof(buffer)); - zwarnnam(nam, "error in pcre matching for /%s/: %s", plaintext, buffer); + zwarnnam(nam, "error in pcre matching for %s: %s", *args, buffer); } if (pcre_mdata)