From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id 042D122640 for ; Thu, 21 Mar 2024 00:49:21 +0100 (CET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1710978561; b=PvweYWhphpN2sZbb5R9flmG9Nbn/pzJywImjK9B/v5/VeTLwgtE06316aPStDHfytS+7Qxq5pn XOJupv/mCKcx3yLWz36YMhvBI4ctjIpWd9yFZPVuge/Aa2y2ndfDMT8n0Mw+KkgNI+4Rm+V4pU FULa5oz7+YjF3Hu78FVNSqU3UTAM5QeRyg6oIiuYEGYY6Xrrmrez3gQxDwtSngh+oqfKpNKR2n ndBlRvEpL+g6dDDUfXhoucBqcC81qZanSXpB/KdjSMSXNDpJZsrUbjYO+BZIJR6fZbcsTsySLU wpN5QiZhmKJCxSQod53b1KoJBsOZh7NmzSjR7UFu2/PCBQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (joooj.vinc17.net) smtp.remote-ip=155.133.131.76; dmarc=none header.from=vinc17.net; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1710978561; bh=w3Y75LUH3kcKnrDt6bEa+8NO6oxHViwdjyr0QnimF5U=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:To:From:Date:DKIM-Signature; b=A9Gt96pIEi6huzdxjci61+OrAwwWdLN4XEqvdx80VBhCfmkWTZ64J9ydWTDfCZSpPMt0yEmdKT l/tJSVoYFdM/zJj8b1rpXTw+BGsJNmC8tkj9A2qb+riNPXPWYrfiknWgkPJcJ/7QVnVY1wU4Fp 51jrQlSHfvu+avpC6ojAVDcXO+4vTQ5qOrmUc97q33z0v7jXTzm5fBgBpyr9uTQqeoOc9wlotZ wON5P2ejkdSak6JmH6zviBeLBPTKTVZuME4VIpn6tCZjOTF1AhLVZIG8fu8G3QZhtTibIj6FfH 232CAxn3jokm5bFVIqZPYlqu+6UQb88+3EvObZUgwTYM9w==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=mZ3+n5S5abD0KSaHoSuXbHz8ELUxiwLG2RJSA4xqVTk=; b=UQs3mdWkSzJbZw5FcBCHrFNGsb fx2ERxgOySEefc4dfLUQkpc/xeh95THxV7OQYNPLoV+o0hrsCcN86iXf1IbNii5EiTxj9pHo7VtsO mMOLBla5i1bqOPXsJkLGEZclev6ftTuqaVG6FA8g9qfcj2TnvxlPm3uVx5n/H4auo2ssSjlw7Qeoa TN/+k8TLjpQPyCex7xSrmqHXONiZhuJID0sZUkpi4M1NSH15QDEQOWv2iLpbC8Ds3G4poky+kJ4W/ bKT3oKjg0VSAQOJDhTYgyNtQaOARXHg27mImkj3jGANyqphszQ+rPDJ0zeNI24Ow5WUhoGjLBfQbt 67FN2gjA==; Received: by zero.zsh.org with local id 1rn5gP-00070g-1S; Wed, 20 Mar 2024 23:49:21 +0000 Authentication-Results: zsh.org; iprev=pass (joooj.vinc17.net) smtp.remote-ip=155.133.131.76; dmarc=none header.from=vinc17.net; arc=none Received: from joooj.vinc17.net ([155.133.131.76]:36422) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1rn5fq-0006fZ-UJ; Wed, 20 Mar 2024 23:48:47 +0000 Received: from smtp-qaa.vinc17.net (135.197.67.86.rev.sfr.net [86.67.197.135]) by joooj.vinc17.net (Postfix) with ESMTPSA id 0DD933D8; Thu, 21 Mar 2024 00:48:46 +0100 (CET) Received: by qaa.vinc17.org (Postfix, from userid 1000) id B445ECA00B0; Thu, 21 Mar 2024 00:48:44 +0100 (CET) Date: Thu, 21 Mar 2024 00:48:44 +0100 From: Vincent Lefevre To: zsh-workers@zsh.org Subject: Re: HIST_IGNORE_DUPS also ignores command lines that differ by a space between quotes Message-ID: <20240320234844.GC4811@qaa.vinc17.org> Mail-Followup-To: zsh-workers@zsh.org References: <20240313123817.GA3492761@cventin.lip.ens-lyon.fr> <20240315125317.GC3738413@cventin.lip.ens-lyon.fr> <20240319105745.GA4811@qaa.vinc17.org> <20240319123444.GB4811@qaa.vinc17.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailer-Info: https://www.vinc17.net/mutt/ User-Agent: Mutt/2.2.12+69 (354c5b11) vl-149028 (2023-12-10) X-Seq: 52784 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On 2024-03-20 10:46:44 -0700, Bart Schaefer wrote: > So how about this as a compromise: > > diff --git a/Src/hashtable.c b/Src/hashtable.c > index 75b06c4ad..e1f575a52 100644 > --- a/Src/hashtable.c > +++ b/Src/hashtable.c > @@ -1397,6 +1397,14 @@ histstrcmp(const char *str1, const char *str2) > { > while (inblank(*str1)) str1++; > while (inblank(*str2)) str2++; > + > + /* If significant whitespace has already been eliminated, (insignificant) > + * there is no reason to expend similar effort here. Also, > + * this is more accurate in cases of quoted whitespace. > + */ > + if (isset(HISTREDUCEBLANKS)) > + return strcmp(str1, str2); That's OK for me. The documentation of HIST_IGNORE_DUPS in the man page should also be corrected / completed. FYI, I had noticed this issue while I was doing tests on various inputs (provided by "echo ... | command"), where I had to test with different numbers of spaces, as they really matter. And I got surprised that I didn't find some of my inputs in the history. -- Vincent Lefèvre - Web: 100% accessible validated (X)HTML - Blog: Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)