From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bounce+ml==a==inbox.vuxu.org==zsh-workers@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED
	autolearn=ham autolearn_force=no version=3.4.4
Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368])
	by inbox.vuxu.org (Postfix) with ESMTP id BB039223C4
	for <ml@inbox.vuxu.org>; Tue, 26 Mar 2024 01:00:30 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org;
	s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:
	List-Subscribe:List-Help:List-Id:Sender:Message-ID:Date:Content-ID:
	Content-Type:MIME-Version:Subject:To:References:From:In-reply-to:cc:Reply-To:
	Content-Transfer-Encoding:Content-Description:Resent-Date:Resent-From:
	Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID;
	bh=bfch5HXSFellDEXXPFvoyjAQSePxHQV+uHnNmibhPro=; b=RVOhAaSYjJFFrQN55S8JMHWtDN
	UXqW4HpofrvYI+D/qbzFm7DHoDFZDESxa+J8g4sOTzEYAedxrkgTgtYOIPGxMSx2rxH3r5mZDgfDg
	yAUZks82aglwmFZHLlbclml+sYM91BuJIeWYGrKUXa/s1G09qQN/XvkbzIMST73t6d717vNdH9fWB
	UIBqY6QqfDwvD6pBfPjX9L0Z2+zx4gBcYu/IWLKMGk1Vs0ltnJBFyCr3NYFX3B59+iy9x+Jq9AO8n
	2osnWNxGZRj3LEt7zYXC9q1fgwFPckGpw2DTeoC1t4p9cBfnhXA2mEMd8JKcJWCop52s41RWMjJsq
	C+DIVAGQ==;
Received: by zero.zsh.org with local
	id 1rouEw-000B7I-63;
	Tue, 26 Mar 2024 00:00:30 +0000
Received: by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256)
	id 1rouE8-000AkB-La;
	Mon, 25 Mar 2024 23:59:40 +0000
Received: from [192.168.178.21] (helo=hydra)
	by mail.kiddle.eu with esmtp(Exim 4.97.1)
	(envelope-from <opk@zsh.org>)
	id 1rouE8-000000008pD-0yGi;
	Tue, 26 Mar 2024 00:59:40 +0100
cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
In-reply-to: <fa3e4452-16d3-43d7-8b62-b112069c1357@zentaur.org>
From: Oliver Kiddle <opk@zsh.org>
References: <fa3e4452-16d3-43d7-8b62-b112069c1357@zentaur.org>
To: Clinton Bunch <cdb_zsh@zentaur.org>
Subject: Re: [PATCH 1/1] zsh/random module
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <33925.1711411180.1@hydra>
Date: Tue, 26 Mar 2024 00:59:40 +0100
Message-ID: <33926-1711411180.228414@bsCA.-gfZ.3NP_>
X-Seq: 52818
Archived-At: <https://zsh.org/workers/52818>
X-Loop: zsh-workers@zsh.org
Errors-To: zsh-workers-owner@zsh.org
Precedence: list
Precedence: bulk
Sender: zsh-workers-request@zsh.org
X-no-archive: yes
List-Id: <zsh-workers.zsh.org>
List-Help: <http://www.zsh.org/sympa/help>, <mailto:sympa@zsh.org?subject=HELP>
List-Subscribe: <http://www.zsh.org/sympa/subscribe/zsh-workers>, <mailto:sympa@zsh.org?subject=SUB%20zsh-workers>
List-Unsubscribe: <http://www.zsh.org/sympa/signoff/zsh-workers>, <mailto:sympa@zsh.org?subject=SIG%20zsh-workers>
List-Post: <mailto:zsh-workers@zsh.org>
List-Owner: <mailto:zsh-workers-request@zsh.org>
List-Archive: <http://www.zsh.org/sympa/arc/zsh-workers>

Clinton Bunch wrote:
> +startitem()
> +vindex(SRANDOM)
> +item(tt(SRANDOM)) (
> +A random positive 32-bit integer between 0 and 4,294,967,295.  This parameter
> +is read-only.
> +)

It'd be useful to spell-out exactly what the "S" in the name stands for.

> +static int
> +ztr_to_hex(char *out, size_t outlen, uint8_t *input, size_t inlen)

Nothing calls this function does it? I'm guessing this is leftover from
the builtin in earlier patches.

Oliver