From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: Test failures in --disable-multibyte
Date: Tue, 31 Dec 2019 19:46:23 +0000 [thread overview]
Message-ID: <43145cb5fdd27a0e8a9f97d1e620e6199bda7c49.camel@ntlworld.com> (raw)
In-Reply-To: <20191231183934.evojovmj7r5bwjnl@tarpaulin.shahaf.local2>
On Tue, 2019-12-31 at 18:39 +0000, Daniel Shahaf wrote:
> In the circumstances, I wonder if we should just make those functions a hard
> dependency and remove the --disable-multibyte (#ifndef MULTIBYTE_SUPPORT)
> codepaths entirely.
It's not generally expected you'll want to disable multibyte explicitly,
but it tests the case you get if you have a system which doesn't have
the required multibyte support. It's not clear if zsh gets compiled on
such systems now --- they won't be very common but there might be some
deliberately reduced systems for low-level use. These only need testing
in a similarly limited fashion.
pws
next prev parent reply other threads:[~2019-12-31 19:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 18:39 Daniel Shahaf
2019-12-31 19:46 ` Peter Stephenson [this message]
2020-01-01 13:44 ` Daniel Shahaf
2020-01-01 18:01 ` Peter Stephenson
2020-01-02 11:30 ` Daniel Shahaf
2020-01-03 10:15 ` Peter Stephenson
2020-01-03 20:11 ` [PATCH] Make --disable-multibyte warn, since the test suite fails in that configuration. (was: Re: Test failures in --disable-multibyte) Daniel Shahaf
2020-01-05 18:20 ` Peter Stephenson
2020-01-05 19:13 ` Daniel Shahaf
2020-01-06 9:44 ` Peter Stephenson
2019-12-31 20:23 ` Test failures in --disable-multibyte dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43145cb5fdd27a0e8a9f97d1e620e6199bda7c49.camel@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).