From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id A30912140B for ; Wed, 20 Mar 2024 17:15:35 +0100 (CET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1710951335; b=sPQ4loZtyparWCLWnoouLl3RgZWFmYANwTxiDoxNt7nsDic/+bM/+kz6woZc8mhD0Rx7K9AhBq filADzpoodxx1Ip9Z+NusCFGWP2ImIjAYCOgu7z3Kq8GjaIqhoGfvLqmWWHNREIeh8UZ9o1j3Z H/SVlN1J7bEgleaO77VmrqrgKEm0/WYolhKq0R/HH6EyIYJ4sXlovzx1+JWyfFEjWEyNunV7RX Pe5rzfuqFkS2e/81n7s/Gdxb3QMM9DpNin52RFtnkaEPl8+3TvPo+BHPhhnRXw9fBoDCa/LuhG NVD5lQE4Zds5TrUrD6wiILriiX8E06ddSqgRtwgPbPgLOA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (csmtpq3-prd-nl1-vmo.edge.unified.services) smtp.remote-ip=84.116.50.34; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1710951335; bh=XK+HQ9LT+uJA1d/jJUTu5YUJUcUFVaCWvRr4VlIgsE8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:To:From:Date:DKIM-Signature: DKIM-Signature; b=KbxdGVi5hzyHc8zyBGAtPsWcnvdebGvSnAkP1Vsp5kQF8cTatpSYFK0RB5CL8XZR8BZMi0j+00 hDW1e6CVzKpYTyzl9QRCGsUWjzuzv7lsTPdog6c8w1IxEwny4vtmhg+QIj2j58Ia5NHpIwvRjM Fx3ae5hoCyaQP6eGFSq7fVAS66HZNAAhVyE61Av6fJ9yZmpbDmYbVRfxhaNoH0bk+Rg1APw7RQ 7rrigI2x/6r9/5HpI2fVH5Ua07G/TKDvnwouAvIYH7lDj43SxF+Kxh9KVdhFYwsCAcP0zv2Y91 UKHTYzAMWQVJptbsljSDxkJ2PIqxh1aBfm5TKSOVdAbv8w==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:To:From: Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=3dqf2SNXoUVe8DqVC/rW27Kvcy9pQfTq5DpeDOlRMuQ=; b=lBcCw3SBNodpk/4YDf5ygU1Kum w6nWg3BKTge8azpplQ2peTTC3Aa6siHI467o4yIUnenCGysTm3CbuwavQ9fZwxcdEn60l+udYR9WS hVJ0UEQvB/+H7ec9Sq6achNYlpWgajewe/HujRUqwaztt6AMP3ARSMBlajJ300lebAnIvxA8OkUSA hTSekytxlxFboUktr1iUyAffhi4haH8u2WFmoB3/HJvsQ9Kj9AlwUKG3JRBShY4Ij8EWhEgm1AZPR wPflC2rlBRrWwQQZT2plU902jgQEyhjw1rrOkhmEBX45T6a0HUEUDx10WEf1sSG/TdnF7YSLkjNMc X0YZOjtw==; Received: by zero.zsh.org with local id 1rmybG-000JWK-Ep; Wed, 20 Mar 2024 16:15:34 +0000 Authentication-Results: zsh.org; iprev=pass (csmtpq3-prd-nl1-vmo.edge.unified.services) smtp.remote-ip=84.116.50.34; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from csmtpq3-prd-nl1-vmo.edge.unified.services ([84.116.50.34]:37873) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1rmyay-000JDN-Cu; Wed, 20 Mar 2024 16:15:17 +0000 Received: from oxsmtp1-prd-nl1-vmo.nl1.unified.services ([100.107.83.138]) by csmtpq3-prd-nl1-vmo.edge.unified.services with esmtp (Exim 4.93) (envelope-from ) id 1rmyaw-00E3xZ-Ku for zsh-workers@zsh.org; Wed, 20 Mar 2024 17:15:14 +0100 Received: from oxbe15-prd-nl1-vmo.nl1.unified.services ([100.107.83.20]) by oxsmtp1-prd-nl1-vmo.nl1.unified.services with ESMTP id myawrTvHswUVGmyawrpNw3; Wed, 20 Mar 2024 17:15:14 +0100 X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 100.107.83.20 X-CNFS-Analysis: v=2.4 cv=EPEA0UZC c=1 sm=1 tr=0 ts=65fb0b92 cx=a_exe a=walA607ud8xbxlZ8F9CWtA==:117 a=IvlwODmuRu4A:10 a=IkcTkHD0fZMA:10 a=If2VLsBYAAAA:8 a=sqBIzgR1G3-qNwqm3GcA:9 a=QEXdDO2ut3YA:10 a=HbQOABYz3jhqdZF7JfnK:22 a=ZCxjKSnKyCmnrEQjtP-5:22 X-Authenticated-Sender: p.w.stephenson@ntlworld.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ntlworld.com; s=meg.feb2017; t=1710951314; bh=XK+HQ9LT+uJA1d/jJUTu5YUJUcUFVaCWvRr4VlIgsE8=; h=Date:From:To:In-Reply-To:References:Subject; b=KoJYZXFgXqyMnvdodaUh2PQehIScNilaA2Rpz3vz7DxBOt8n1MnC7oH7COklOIzeu jwDL6RumAEHgSJdYiXlrf/jdg4qhHNQcMxKDKYADIFwZBj3aU6WkNHC1WqqKkuhper L8S7LECkG3UnVWPsN7E7SYVPKgaB9Mopa4wO5i62kTIjc9RWIAgAwvNNpd51SHayMG YZrO9BSrBtZolGaDwMqmvhjgWwk0qkZM2Q8TOaavj9vntXiCxStPNC2qzR5RiBRzLh kU1BzIO3i7aIsPR82PKjO45e7Z5MszqpPJrLtQn5Rurvd7ssK/vZN6yXLMyrt5QE1T 0hkq5rbaNbiVQ== Date: Wed, 20 Mar 2024 16:15:14 +0000 (GMT) From: Peter Stephenson To: Clinton Bunch , zsh-workers@zsh.org Message-ID: <615589318.5857173.1710951314600@mail.virginmedia.com> In-Reply-To: <7e9a2bfd-3a91-4c19-ad11-0397a839be4f@zentaur.org> References: <4660bb1c-c15f-41a0-bd7b-0da19073a534@zentaur.org> <1922525261.5866551.1710927037473@mail.virginmedia.com> <947945847.5869623.1710929963847@mail.virginmedia.com> <7e9a2bfd-3a91-4c19-ad11-0397a839be4f@zentaur.org> Subject: Re: current git Fails to compile on Solaris 11 x86 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer X-Originating-IP: 147.161.224.196 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4xfJIgj2mJSILeEt4Wt2OjetWyBvOHrzpblJ21ISq+JxKm81NO1mANPda3zpcIrtZ9hXMf+cvPDZR1UBsoINStYwOrOdPwJdo/H0q/QWGbuIi2l/7w1io0 IT/ETodyyVd5Z6jXsWfWN1mCrqiR5jqAPVTaL7hPq2SaN4P9b/xchRiAZFbci2ldfSI9LPKlro+uxM3BAoC1loG9INbsfh3gK1gyQGkgez3DCURLJ4MIyr5V 3qgG7b26IsCWKRE7yJPdydhXFZMTZqSoP0uooTHBElk= X-Seq: 52780 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: > On 20/03/2024 15:05 GMT Clinton Bunch wrote: >=20 > =20 > On 3/20/2024 9:54 AM, Bart Schaefer wrote: > > On Wed, Mar 20, 2024 at 5:22=E2=80=AFAM Clinton Bunch wrote: > >> On 3/20/2024 05:19, Peter Stephenson wrote: > >>> Let's just rename it and the others in that area. > >>> > >> I'm getting the same error with that patch applied. What I saw on th= e > >> lines it errored on were return statements returning the value of a > >> function in a wrapper function defined to return void. Perhaps, simply > >> removing the return keyword? > > Yes, just removing the "return" from the void function is all that's ne= eded. > What I was unsure of was whether removing the return or changing the=20 > type of the wrapper function was the appropriate fix.=C2=A0 That would=20 > require more familiarity with the code than I have (or at this time want= =20 > to put in the effort to get) to answer.=C2=A0 I mostly wanted to make oth= ers=20 > aware of the problem. The wrapper function just fits a generic form, so should stay void. It's as simple as it looks. (I guess the line numbers were out in the code I was looking at so I misidentified what it was complaining about.) diff --git a/Src/Modules/hlgroup.c b/Src/Modules/hlgroup.c index 6382f32..230f453 100644 --- a/Src/Modules/hlgroup.c +++ b/Src/Modules/hlgroup.c @@ -137,7 +137,7 @@ getpmesc(UNUSED(HashTable ht), const char *name) static void scanpmesc(UNUSED(HashTable ht), ScanFunc func, int flags) { - return scangroup(func, flags, 0); + scangroup(func, flags, 0); } =20 /**/ @@ -151,7 +151,7 @@ getpmsgr(UNUSED(HashTable ht), const char *name) static void scanpmsgr(UNUSED(HashTable ht), ScanFunc func, int flags) { - return scangroup(func, flags, 1); + scangroup(func, flags, 1); } =20 static struct paramdef partab[] =3D {