From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: function copy
Date: Mon, 15 Jul 2019 22:25:52 +0100 [thread overview]
Message-ID: <641de8a0b26f713e1f10203aeccbe8a8b9b3769e.camel@ntlworld.com> (raw)
In-Reply-To: <CAKc7PVAJtt5v0U5V93Aov06gy7c4-UGFB6kKWqNoWKcE17g4hQ@mail.gmail.com>
On Mon, 2019-07-15 at 22:23 +0200, Sebastian Gniazdowski wrote:
> On Mon, 15 Jul 2019 at 22:01, Peter Stephenson
> <p.w.stephenson@ntlworld.com> wrote:
> > + if (OPT_ISSET(ops,'c')) {
> > + Shfunc newsh;
> > + if (!*argv || !argv[1] || argv[2]) {
> > + zwarnnam(name, "-c: requires two arguments");
> > + return 1;
> > + }
>
> I'm probably wrong, as the tests should caught that up, but should the
> "argv[2]" in the line:
>
> > + if (!*argv || !argv[1] || argv[2]) {
>
> actually say "!argv[2]"?
It it's an error if argument zero is empty, or argument one is empty, or
argument two is non-empty.
pws
next prev parent reply other threads:[~2019-07-15 21:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 20:00 Peter Stephenson
2019-07-15 20:23 ` Sebastian Gniazdowski
2019-07-15 21:25 ` Peter Stephenson [this message]
2019-07-15 21:42 ` Bart Schaefer
2019-07-15 21:51 ` Sebastian Gniazdowski
2019-07-15 22:08 ` Bart Schaefer
2019-07-16 8:56 ` Peter Stephenson
2019-07-16 16:55 ` Philippe Troin
2019-07-16 19:06 ` Bart Schaefer
2019-07-16 19:11 ` Bart Schaefer
2019-08-03 18:58 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641de8a0b26f713e1f10203aeccbe8a8b9b3769e.camel@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).