Hello Peter,

when emacs is wrapped inside function,
then emacs is dead when:

^Z
bg

Does not happen when emacs called w/o function.
See minimal .zshrc attached.


% su -l heinb
Password:
tosh% emacs

zsh: suspended  emacs
tosh% bg
[1]  + continued  emacs
tosh%
[1]  + suspended (tty output)  emacs
tosh% jobs -l
[1]  + 20708 suspended (tty output)  emacs
tosh% fg %1
[1]  + continued  emacs
tosh% eclient
zsh: suspended  eclient
tosh% jobs -l
[1]  + 20718 suspended (signal)  eclient
tosh% bg
[1]  + continued  eclient
tosh% jobs -l
[1]  - 20718 running    eclient
tosh% fg %1
[1]  - running    eclient
<<<#### here terminal is broken


This is still even after 551ff842721d6ca83727dbe6cd40178f46cc8201
aka "43464: Another attachtty() fix."



HTH



kind regards,

     Thilo


TS schrieb/wrote:
> Hello Vincent,
> 
> please refine your bugreport. I am not able to reproduce your report.
> basically: emacs != eclient
> 
> % su -l heinb
> Password:
> tosh% emacs
> 
> zsh: suspended  emacs
> tosh% bg
> [1]  + continued  emacs
> tosh%
> [1]  + suspended (tty output)  emacs
> tosh%
> 
> i now undestand upsteam.
> 
> this is with zsh git tag 5.6.2
> 
> 
> 
> kind regards,
> 
>      Thilo
> 
> Vincent Lefevre schrieb/wrote:
>> On 2018-09-16 10:40:20 +0200, Vincent Lefevre wrote:
>>> On 2018-09-15 21:06:56 +0200, TS wrote:
>>>> Test case, tested with 5.6.2:
>>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=908818;filename=.zshrc;msg=66
>>>>
>>>> result for me:
>>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908818#66
>>>
>>> I think I have noticed issues with "less" using zsh-5.6.1-10-g24bb465
>>> but I didn't remember what I did exactly and I couldn't reproduce
>>> them. I needed to do a fg.
>>
>> The session in the terminal looks like that:
>>
>> zira:~/software/mpfr> emacs                                            <3:13:29
>> ^Zzsh: exit 148
>> zsh: suspended  eclient
>> zira:~/software/mpfr[TSTP]> bg                                         <3:13:33
>> [1]  + continued  eclient
>> zira:~/software/mpfr> less src/Makefile                                <3:13:38
>> zsh: suspended (tty output)  less src/Makefile
>> zira:~/software/mpfr[TTOU]> fg                                         <3:13:42
>> [2]  + continued  less src/Makefile
>> zira:~/software/mpfr>                                                  <3:13:42
>>
>> In short:
>>
>> 1. Run emacs[*] (with its X interface).
>> 2. Type Ctrl-Z in the terminal to stop Emacs and get the prompt.
>> 3. Type "bg".
>> 4. View a file with "less"[*].
>> 5. Quit Emacs (while "less" is still running).
>> 6. Quit "less" (with 'q').
>>
>> This yields a TTOU on "less" (see above). Note that 2+3 cannot be
>> replaced by the use of "emacs &".
>>
>> [*] This is actually a shell function:
>>
>> eclient () {
>>         emulate -LR zsh
>>         local display i
>>         if [[ -n $GNUCLIENT_ENABLED ]]
>>         then
>>                 display="$DISPLAY" 
>>                 for i in "$@"
>>                 do
>>                         [[ "$i" == "-nw" ]] && unset display
>>                 done
>>                 [[ -n $display ]] && gnuclient "$@" 2> /dev/null || \emacs "$@"
>>         else
>>                 \emacs "$@"
>>         fi
>> }
>>
>> with GNUCLIENT_ENABLED not defined.
>>
>