From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18797 invoked from network); 12 Apr 2021 08:19:03 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 12 Apr 2021 08:19:03 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1618215543; b=OcsC6JQ0zAwaK0vNWNjV5IcYbyBtlY2Y3+zPkT17bBoURfrgBoCYFolS04LCkpEGNqvLQWTk1W VZmBGKS16qNW+rZ43zn3KHC65hD3L6GEvDVf95vZS4030T3vYVZaw9MIMcQ6l8JvSgrfwbpsAb vb2KrVOhfCpNgrVWwbrbRebj1RTl9ZxWCiwyMsapBoLRvGrA93AVPGvLxAkDuPFM1D9/sfAbAh Sb9sDW51fwUQPS4Hh6WYKdZhYJMRNksCY2LPZkhSIQ4H7DklBgdJtutrXFtHvjkUbaJ/4Mmbdd l7+ivSQGBJUGqBIIruJlzX+JSMuXVTEzSSHqC+WkHIRGRg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lf1-f46.google.com) smtp.remote-ip=209.85.167.46; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1618215543; bh=9rtU/gjMuOZEcAB4cpMA0PW5g1SBpyELIoTV4KZQTfc=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:To:References:Message-ID:Content-Transfer-Encoding:Cc:Date: In-Reply-To:From:Subject:MIME-Version:Content-Type:DKIM-Signature: DKIM-Signature; b=WY/nwkvMIv2oWuGwZyewCQHGCw25SDj+mPX7qCu2I35T7v09zKTcP75EvjKuT8oA4axxT32IhA hVo2yaBzQwnuc7hp2rPiWU+z7VOhOrc/fGgCzLUstVvelX1ZcW5s5pPfE/88JAKMgWE+Cibe/h b3mF5C6VNExQ8RxDF4bi/ioM4TmsqHcxvgENCCWUI5B7Swbp42iCyXQ67nfmTpZHZxSaAat9/G rdrmKwUXWTakKrHkWpbKM57fX8huVAVozNMJFpajKSJ8P34Zi+1JI2O8CTvYGIRXA/OqiDATON hHuDAG4MhGp8cR9iZfcBP0IbH4Ddsmo4mxpwF8RIJerTQw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:To:References:Message-Id: Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version: Content-Type:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=wzeQrUaHgT43u0/5vzQhmIembrvY5GFNPAygqBBPfag=; b=saNIqBIzFQM2ki/42gwXAhKt2z nGow2sCgh3DXt/mQmZ7ArdHZkMtAN+W4/pmmVHtJdnuyBOdEWqumTGeBHsu+kl2a8e3+YvZtl2xB3 oFQVYy79Aqzq4N2Z9m5f2v3SN9ArrAqnMIf7/nhM4aSdcpFoYmvyVzS9EjPW65OXVCIY17CQ1aWj3 giy1JDqyQDqezeJZ6Dy9pBOoqjBx4dAEQZVqu93GZ6MOCsi+gwq+yHCiqPWuI2+B4ivMceC0jz8jG x2C+mo/yix7jv9euTPSIM1TGpcSQhdTkeo4MFGB/Dkx4Yxql5uOn1CDVtaFhf3+3f+4HAGne5tWJB cejMmlVQ==; Received: from authenticated user by zero.zsh.org with local id 1lVrmf-0000IK-3g; Mon, 12 Apr 2021 08:19:01 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lf1-f46.google.com) smtp.remote-ip=209.85.167.46; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lf1-f46.google.com ([209.85.167.46]:45855) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1lVrmP-00003A-Gv; Mon, 12 Apr 2021 08:18:46 +0000 Received: by mail-lf1-f46.google.com with SMTP id g8so19948644lfv.12; Mon, 12 Apr 2021 01:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=wzeQrUaHgT43u0/5vzQhmIembrvY5GFNPAygqBBPfag=; b=LRDMgcLHYd97JqWbv9/BKLSBCY6GN+3HWghPMrAgT+p98NAFmT9FmWdgPWBdyQGNG7 /iz14C0ucLRat3r1RVzX3xYcU06bjREIO1UDeAz/ZgGSQYuinbNK+oYl9CuyFnRQledM FZM6pLgKSsherxOiOvu7QKWTGtt45jjpyXHyefDwD9bdZjVuqDeKzdYIZf4jC4ks3BjK PpUIquI06BXn+RVbNxoJEw9iwA8TAHFDW+obt8Ss5aFyN4D9GkTy4w/s8P2aczQCoohk rz6wksqaU1fLRUIUXviWnzCaiX5S9VTfli8ZG6Up8xdoEHBToPGw6gy3Zp8Yq6zitI6v cEww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=wzeQrUaHgT43u0/5vzQhmIembrvY5GFNPAygqBBPfag=; b=aV0kbanRTUilyefCNcsPTlvv4zqaWQvEqRYKOIPjAcDcXpJjReyzDIikI0BHtV+JPB UqoEUXxcoI+c/NqgGbH5gGlF9Gkh7LJQP5aZ3zvFtIg2KMYAGK5AM6UzhBHNfgnng8bw CNZcRCIV3tKxkTXNhmHXft4Yb4eYoUT9prTteHM60Nv7IowuLMH2gHyO7sEJYO/BYLqK Wv2r0gvINbmibsVaPug9si4st6OPH7ximGRo3k+ic2DtTDIKBWJR2PZKRf+XCdlwAUeC Ok+opAmXOfVwnWMsg84Z9s5trnZxupaTo9vWtc+3tZoQojnUMz9pkVf/cVH/wCGc4lKx n8LQ== X-Gm-Message-State: AOAM530KbKDT++JELAhAHE0IXvPkJx99xJRFiqAdMrRVvP/pNE4zO2pr 5l0bcO48EAydug8mvzXfLcDLK81mD12PyQ== X-Google-Smtp-Source: ABdhPJw9y6uFEiLq1ER5Ldoh2AVN7JhmK8f3T+RkNHFpJdI0Z5gkGdPu42y/T2qa8ohm4mSi84F2Iw== X-Received: by 2002:a19:4cc2:: with SMTP id z185mr17587109lfa.461.1618215524670; Mon, 12 Apr 2021 01:18:44 -0700 (PDT) Received: from [192.168.1.15] (hag-tkubng22-50df3e-132.dhcp.inet.fi. [80.223.62.132]) by smtp.gmail.com with ESMTPSA id d10sm2230800lfn.159.2021.04.12.01.18.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Apr 2021 01:18:44 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: Patch bumping (was Re: Feature Patch: Use completion to view parameter values) From: Marlon In-Reply-To: Date: Mon, 12 Apr 2021 11:18:43 +0300 Cc: =?utf-8?Q?Lawrence_Vel=C3=A1zquez?= , Zsh hackers list Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210329073913.GP18178@tarpaulin.shahaf.local2> <20210329171120.GA6044@tarpaulin.shahaf.local2> <20210329181452.GB6044@tarpaulin.shahaf.local2> <18618-1617324651.844569@tLsN.0hLE.FeTt> <2c44b17c-407d-449e-be2e-610db313c1d7@www.fastmail.com> To: Bart Schaefer X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Seq: 48510 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: > On 12 Apr 2021, at 00:24, Bart Schaefer = wrote: >=20 > With appreciation for Lawrence's efforts, I'd respectfully request > that the criteria for when to send a "bump" become a matter of record. >=20 > There seem to me to be these cases: >=20 > 1. The patch has never been reviewed or discussed. > 2. The patch was reviewed and is acceptable, but was never applied. > 3. There was a discussion, but it ended without resolution. > 4. The patch was referred back to the author after review or = discussion. >=20 > There is room for subjective interpretation of "is acceptable". A > possible resolution of #2 is that the patch is rejected after all > (perhaps it has become obsolete in the meantime). >=20 > I mention this mostly because I think the useful elapsed time before > "bumping" might be different in each case. In particular #4 seems > like it could be left considerably longer, unless the patch is fixing > a serious bug or security issue. >=20 > Thoughts? I would suggest the following minimum wait times before bumping: * To remind about an unresolved patch (not yet reviewed, not yet = responded to by author after review, not yet = accepted/rejected/committed, etc.): * security issues: 2 days * critical bug fixes: 1 week * all other patches: 2 weeks * Everything else: 1 month Additionally, it would be helpful if committers remember to inform us = when a when a patch has been accepted/rejected/applied, to avoid = unnecessary bumps.