From: Bart Schaefer <schaefer@brasslantern.com>
To: Roman Perepelitsa <roman.perepelitsa@gmail.com>
Cc: Marlon Richert <marlon.richert@gmail.com>,
Daniel Shahaf <d.s@daniel.shahaf.name>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Functions/Misc/colors vs. region_highlight
Date: Fri, 23 Oct 2020 17:50:08 -0700 [thread overview]
Message-ID: <CAH+w=7YDH-WPzaPJ=TfyN_mAmaA+jHthdhZOrP-rnQL2XzsLLA@mail.gmail.com> (raw)
In-Reply-To: <CAN=4vMoUZExCRW4u=+D_LPgQBf4HoLFmDiwTaUepbHdJN3qQKw@mail.gmail.com>
On Fri, Oct 23, 2020 at 4:38 AM Roman Perepelitsa
<roman.perepelitsa@gmail.com> wrote:
>
> The fact that region_highlight and zle_highlight support "standout" is
> not a problem but a feature. Standout is a part of the curses standard
> and zsh interprets it within region_highlight and zle_highlight in a
> manner consistent with the standard. ("standout" within "colors" is a
> different matter. That one is incorrect in my opinion.)
You're correct that "standout" doesn't match the terminology in
ECMA-48. The use of "standout" was chosen to follow the terminology
in prompt strings, I believe.
This matched the behavior of most terminals at the time (notice
${(k)color[(r)standout]} is actually from Sven all the way back in
2001). Also, there's no way to directly reference an escape sequence
for any of the "Attribute Codes" (they aren't in the $fg / $bg
hashes), so those values are mostly there for commentary value.
I would have no objection to adding "italic"/"no-italic" to the color
hash. It also appears standout would more accurately be tied to
reverse-video now, but because the keys of the hash are the numeric
codes we can only have one or the other.
diff --git a/Functions/Misc/colors b/Functions/Misc/colors
index 027ca9a14..b221e6688 100644
--- a/Functions/Misc/colors
+++ b/Functions/Misc/colors
@@ -14,11 +14,12 @@ color=(
00 none # 20 gothic
01 bold # 21 double-underline
02 faint 22 normal
- 03 standout 23 no-standout
+ 03 italic 23 no-italic # no-gothic
04 underline 24 no-underline
05 blink 25 no-blink
# 06 fast-blink # 26 proportional
07 reverse 27 no-reverse
+# 07 standout 27 no-standout
08 conceal 28 no-conceal
# 09 strikethrough # 29 no-strikethrough
next prev parent reply other threads:[~2020-10-24 0:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 9:22 region_highlight converts `fg=default` to `none`, which is not the same Marlon Richert
2020-10-13 11:05 ` Roman Perepelitsa
2020-10-14 5:12 ` Marlon Richert
2020-10-14 20:46 ` Daniel Shahaf
2020-10-15 7:37 ` Roman Perepelitsa
2020-10-15 16:58 ` Marlon Richert
2020-10-15 17:09 ` Roman Perepelitsa
2020-10-16 13:36 ` Daniel Shahaf
2020-10-24 1:34 ` Oliver Kiddle
2020-10-24 6:42 ` Roman Perepelitsa
2020-10-16 13:28 ` Daniel Shahaf
2020-10-16 15:50 ` Bart Schaefer
2020-10-22 19:58 ` Marlon Richert
2020-10-22 23:28 ` Daniel Shahaf
2020-10-23 8:08 ` Roman Perepelitsa
2020-10-23 9:24 ` Marlon Richert
2020-10-23 9:35 ` Roman Perepelitsa
2020-10-23 10:40 ` Marlon Richert
2020-10-23 11:38 ` Roman Perepelitsa
2020-10-24 0:50 ` Bart Schaefer [this message]
2020-11-03 18:54 ` Functions/Misc/colors vs. region_highlight Marlon Richert
2020-11-03 23:45 ` Bart Schaefer
2020-11-04 15:47 ` Marlon Richert
2021-04-18 21:40 ` Bart Schaefer
2020-10-23 23:57 ` Threading across year boundaries (was: Re: region_highlight converts `fg=default` to `none`, which is not the same) Daniel Shahaf
2021-03-31 8:26 ` region_highlight converts `fg=default` to `none`, which is not the same Marlon Richert
2021-04-10 20:33 ` Lawrence Velázquez
2021-04-13 15:20 ` Daniel Shahaf
2021-04-13 20:33 ` Roman Perepelitsa
2021-04-14 11:04 ` Daniel Shahaf
2021-05-09 20:49 ` Lawrence Velázquez
2021-05-31 1:16 ` Lawrence Velázquez
2021-03-31 8:24 ` Marlon Richert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YDH-WPzaPJ=TfyN_mAmaA+jHthdhZOrP-rnQL2XzsLLA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=d.s@daniel.shahaf.name \
--cc=marlon.richert@gmail.com \
--cc=roman.perepelitsa@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).