zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Nofork ${{var}...} edge cases
Date: Wed, 27 Mar 2024 18:12:20 -0700	[thread overview]
Message-ID: <CAH+w=7YZSRLqDFoU+5SoGGKQsYvuNF-VONALefBnuZTLzcB5wQ@mail.gmail.com> (raw)
In-Reply-To: <CAHYJk3QRHHO8BUPEs1W5dpTukGJbePAw14fq_RgzgibXf0BcRQ@mail.gmail.com>

On Wed, Mar 27, 2024 at 5:29 PM Mikael Magnusson <mikachu@gmail.com> wrote:
>
> > Should ${{var}} be a "bad substitution", or print a warning about an
> > empty command?  Otherwise it just substitutes $var.
>
> Is a space no longer required after } (formerly ||) to trigger the
> command substitution?

A space was never required, it was just a convention I always followed
when writing examples:
% echo ${|x|x=foo}
foo

mksh doesn't require a space in ${|REPLY=foo} either.

> I personally would like to get an error in this
> case because missing a $ in nested substitutions is a fairly common
> typo.

Yes, I was just musing about that possibility myself.

> Eg I meant ${${var}}. And if no space is required, does that
> mean if you typo ${${foo}:-blabla} into ${{foo}:-blabla}, :-blabla is
> suddenly executed as a command?

With the patch as submitted so far, yes.  But requiring a space there
should be easy, and a pretty reasonable requirement.


      reply	other threads:[~2024-03-28  1:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 18:57 Bart Schaefer
2024-03-27 22:22 ` Oliver Kiddle
2024-03-28  1:00   ` Bart Schaefer
2024-03-28  1:21     ` Bart Schaefer
2024-03-28  1:32       ` Bart Schaefer
2024-03-28  0:29 ` Mikael Magnusson
2024-03-28  1:12   ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7YZSRLqDFoU+5SoGGKQsYvuNF-VONALefBnuZTLzcB5wQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=mikachu@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).