From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id 841B921585 for ; Thu, 21 Mar 2024 20:06:51 +0100 (CET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1711048011; b=hw5lABukpjqkYF0InhT760nFNya3b/GzULD5LC1u8yGZmE/l4suhi1HP/9zn5Yfq8LcL6+b1mh 1kMy+n3OlXaYtoeKvnA8jtTANKg2Ajh0zj/0zWdKHeiSzBKpaK9aHFeEjaEhiFoKi9HqWnIQ4T qUuTrWkQr27fus0Ovpvs3sgF/PcBZuNgdMdS+pRybBaWc4o/k/1WMTW8GONMmLID+ZiAtbtr2T r2Kx51hUtO6kJ6A6f4f9jIa9AOrT5u+d6uyvJwrwng7Wk+0y8dhFLU2HWGFuX79TSNMN5K0DMR A9CFdgbY4tW2jahtGsvgDOmXptXZ1ucNgknwGfUKEpIFDQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f49.google.com) smtp.remote-ip=209.85.218.49; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1711048011; bh=xXvd6afD5WtT9LOtD5vOHn/SDRwQy0Ou5Kylmy3MRlk=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=Ercie2r7GHjBN+3bpVsfAaxfhtqjnrCi1hK984VCXend3VZwwzLM2HqxsiOFHDrJQ3d5D3kPHm sn2jbqxd/xGQlbLyAh37IkMH5shQA7YG8YUepnxNRom1yqY7hzOrwr8cNxMgU6R+xqNJdw0kqi P5CuG0p3N6V+Q73jfRjg2mDdtAV2x0u35ki4SKh95AV86ynb7gCLyDtMRw+yKoqzyRTQrwsEQO wwDGjG/x0CcaPr5nCQnto1++LsjjVWdQQwoiK7g4mDWu0+2dwxHmbjbOVkLulSahqCQOsvRBq+ 1LmSpjpK49BC6XtrqfewkOwguK1hk4IO3ZgAR7YaRRUVlw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Tx3Yd881iVYccPCXerW/qnfkwzauS1ZYQBuQR6aIiwI=; b=I3dbg2n8qKkcunPQ+sVqhHPiXA //zaRzrBJ3WIPf/mLU9upl/644jJMwIMtleeZlCmEWzvtjYpcai6HOwBa7D3ilqbs9JgZOHSNpM1l 4i1Ei/Mem38YnwSCIxq805Je0hnE+4vrxdbXbpJyIr0gfTddU/4fWHYzO7o5bX0BTDzJhBqPJZXRm nGtS9lMBRDqLlpdIMdvKb0HyfluQgobdlnZNOt+JJMpFopZXBPXfGqj4/rkdZeBUaI7M8NB6/TiVR lHd0C678JCSGZS2KOBVlZFabbXWaVsXR9my1OErN5d5jwIDhx+K/NHPe+IDg6wJBpqWRsQ42yJA7c bOXpHYTA==; Received: by zero.zsh.org with local id 1rnNkZ-000J4P-Bc; Thu, 21 Mar 2024 19:06:51 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f49.google.com) smtp.remote-ip=209.85.218.49; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f49.google.com ([209.85.218.49]:55773) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1rnNkF-000IkM-Rt; Thu, 21 Mar 2024 19:06:34 +0000 Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a4644bde1d4so188950466b.3 for ; Thu, 21 Mar 2024 12:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1711047991; x=1711652791; darn=zsh.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Tx3Yd881iVYccPCXerW/qnfkwzauS1ZYQBuQR6aIiwI=; b=Bz5yH14eAM6WveysJXWq1/0VPRXOKC3+mcs2q6RjEzzl6ruKeg+pzEbDFIU00uPOZn fkXjKwI0Ab9vKM+WLdjBzG3sdCm1e29LDXB9g7ImRsZbgYBotasGOTetTbWgGokn/MSI VSlInxmcGxkQBzfzZWUs8+7qXM5fIhEh0IiePw6tK3T1pk4a4nhN4KYY7LQ/ZY8cWYs5 2/WKm6y0P9/q9BVLSHwwtx707eTHL3MVPxK7cBSATlwonAiERMGGu7HBSOpWHambDp// xYEbxGXlNputBVdI3UllIsbAcdvS1Kd2RvqO3NUiLWv2dWgWbQWuVAQ9a3A3lt/o/GAC RB6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711047991; x=1711652791; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tx3Yd881iVYccPCXerW/qnfkwzauS1ZYQBuQR6aIiwI=; b=sDe38CW1qJs3h7pkiXNCQzCEJh18oqsQYSNnbjLbEseRsm6jCJe31XBGq8W0UwxU+Y MZEkTEH43Ecwm9kHN2nq4g97HLHoWeCb4N+c9lSD/fgpI/Vu7EKA65m2Q/xYt6JibTSF z98qMF+hjnWrqmxDegWUGEJcI+wX/N8+zujIj5vJ3ft2E1dK3z50yi76KopR1b2QJvMX Uloty+V1mwxBHYvGUaRm73+XI+IVMDmsYX4M4QJKN0PV9DcNJS3cOnfs57nFhjxEplhe ntmpKbFIn/8NkXae5Dzhdt+5V2RJR/24nU5JWlygngQ1TIa9r0HyVE6ivp0eIMJWfmu5 E5lw== X-Gm-Message-State: AOJu0YxVzcvq1duBY3EZjL3gIFryfAGOgPLlpqejT0ozvsHCK5Gil7IG yJytFFPFcMgrU0RskkB7kjX5OgFObqMc8cFE47NCNAdO+DsFO6o8FiovW/YWDjmNSE5bbGF1nfQ x3rYJjLI447d5PzgJ5SIqN1s81CDgWUMucoHq X-Google-Smtp-Source: AGHT+IH51MxiNjHcgz6LZERmFa2gTtE1OXK3m5vmkp1Jm5leoT7riTpSWCKEkBLgCF45V1EiPN1Hudt66KE3iihxfww= X-Received: by 2002:a17:906:6bd2:b0:a47:1d90:820 with SMTP id t18-20020a1709066bd200b00a471d900820mr215582ejs.70.1711047991301; Thu, 21 Mar 2024 12:06:31 -0700 (PDT) MIME-Version: 1.0 References: <20240321100710.GA164665@qaa.vinc17.org> <1443395979.5911218.1711016896863@mail.virginmedia.com> <20240321110444.GC164665@qaa.vinc17.org> <1507569659.5899391.1711020579178@mail.virginmedia.com> <20240321121826.GD164665@qaa.vinc17.org> <409557737.5903555.1711023912772@mail.virginmedia.com> In-Reply-To: <409557737.5903555.1711023912772@mail.virginmedia.com> From: Bart Schaefer Date: Thu, 21 Mar 2024 12:06:20 -0700 Message-ID: Subject: Re: behavior of test true -a \( ! -a \) To: Peter Stephenson Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 52796 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Thu, Mar 21, 2024 at 5:25=E2=80=AFAM Peter Stephenson wrote: > > I think we factor out simple cases with two or three arguments and > assume they aren't doing grouping or logical combinations, so that might > be OK. Obviously once we're into more complciated expressions it's > going to get fraught Isn't the problem really here? if (n_testargs > 2) { /* three arguments: if the second argument is a binary operator= , * * perform that binary test on the first and the third argument= */ if (!strcmp(*testargs, "=3D") || !strcmp(*testargs, "=3D=3D") || !strcmp(*testargs, "!=3D") || (IS_DASH(**testargs) && get_cond_num(*testargs + 1) >=3D 0)= ) { s1 =3D tokstr; condlex(); s2 =3D tokstr; condlex(); s3 =3D tokstr; condlex(); return par_cond_triple(s1, s2, s3); } } Shouldn't this be doing an expression parse for s3 rather than just lexing a token? Admittedly I'm not sure how that factors in s1 given that s2 is the actual binary operator here.