From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Cc: midchildan <git@midchildan.org>
Subject: Re: [PATCH] add new features and improvements to the "incarg" ZLE widget
Date: Sun, 4 Feb 2024 16:36:55 -0800 [thread overview]
Message-ID: <CAH+w=7YyGmo1zTKgMqevWgoU6Q+_Ah69VFgDJfBZHF5nJYUPGg@mail.gmail.com> (raw)
In-Reply-To: <20240204191938.42759-1-git@midchildan.org>
On Sun, Feb 4, 2024 at 11:37 AM midchildan <git@midchildan.org> wrote:
>
> This brings numerous improvements to the incarg ZLE widget
Thanks for sending. Remarks below, all minor.
> Vim's increment command jumps to the nearest integer after the cursor
> and increments it. I find this behavior very useful when combined with
> history-beginning-search-backward. So I made it possible to get this
> behavior by prefixing vi to the widget name.
Here you say "vi" and in the doc specifically "vim" but in fact any
prefix beginning with "vi" is accepted by the code, I think?
> + if [[ "$WIDGET" == vi* ]]; then
> + # jump to the nearest number after the cursor
Should probably be more precise.
> +++ b/Doc/Zsh/contrib.yo
> @@ -2620,12 +2620,30 @@ zle -N history-pattern-search-forward history-pattern-search)
> +By default, the target integer will be incremented by one. With a numberic
Typo: "numeric"
Thanks for including a test.
next prev parent reply other threads:[~2024-02-05 0:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 19:19 midchildan
2024-02-05 0:36 ` Bart Schaefer [this message]
2024-02-05 16:16 ` midchildan
2024-02-15 15:30 ` Oliver Kiddle
2024-02-28 19:11 ` [PATCH v3] " midchildan
2024-02-28 20:07 ` [PATCH] incarg: add a backward variant and make it repeatable midchildan
2024-02-29 13:34 ` [PATCH v2] " midchildan
2024-03-04 23:20 ` Oliver Kiddle
2024-03-28 23:07 ` Sho Yuhara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YyGmo1zTKgMqevWgoU6Q+_Ah69VFgDJfBZHF5nJYUPGg@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=git@midchildan.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).