From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 2d67fb38 for ; Mon, 15 Jul 2019 21:25:38 +0000 (UTC) Received: (qmail 8683 invoked by alias); 15 Jul 2019 21:25:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44534 Received: (qmail 15528 invoked by uid 1010); 15 Jul 2019 21:25:33 -0000 X-Qmail-Scanner-Diagnostics: from mail-lf1-f51.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25510. spamassassin: 3.4.2. Clear:RC:0(209.85.167.51):SA:0(-1.9/5.0):. Processed in 2.970072 secs); 15 Jul 2019 21:25:33 -0000 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.167.51 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iiGQ4Z1W1jGbYU6fepvkY5JIVicBBZ2EXlTE3RbGktM=; b=D/XDC6Yfs0HfR01hsqg/Hiw4NVCPf6wtDkqszHSPbO/kDFMnuUbrSnmvCZ8e7MGnR2 31ECcUj4ci+OtQKtIU/30cTnx6EJSiSRZY9prGFC7h04V17drLstFklV5JvQx4DASyO0 Ywj81Hhvawjgx5wZPIXFhp9pZooJCqn0UwlWlaTfhFNWbptJynqzCETL9omaUv5v/Rj3 GDn/GcRT1DeZkFtavXX/xzQzz81eRg6BwbSM23CgC89M0EXIqMSDR3Ymtqofdxfj9Te7 hNArEzdFfVBnmEtSCr6TIsUmaD1f2sx2EjHaMB2gsCpW1S3sqciMFsOXTVGAERU7yiVB cRmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iiGQ4Z1W1jGbYU6fepvkY5JIVicBBZ2EXlTE3RbGktM=; b=uM/3W5Q+osJArB3TRn7QHdPOOSlSG9CnCt94XOp75S3kZPEA+wny2EOA+bsqlKMcUG X+6KoUJ2NCrRxc2cM7rYkFmkqD1BHMEs5/xjuAbQstVSJwxrSiYdqG3F4mnUCshKd5ND u6EoEVk3O8LLJZL4+2HodXzMvUq7IgQ1MMl9HyEBBcxWFeSTB4rG44i+F8KQfocqlKqS EWzr4HYfsZOrTpGAE1W7qhhShp+4XmzgZCaASy8va7/t5MFOdd+/YJCURn1O2zc6atTd jLgVXmQTkL4KIF+jkpaChUsq9EZCq04mlm2ThztQRx96GlFOzLolOhZSpdPz+u0ib5ug TBxQ== X-Gm-Message-State: APjAAAUHdZ+ZHFOMHNRwLGCCkPUUn68cJfGrsSsN+16tqwFmI3IM+61e yCvgbksuoJgtTy2lJa00XTsVneYiwLpC2SO6WQw= X-Google-Smtp-Source: APXvYqzuaAfXz2Vgbw8WuTFaU+JlutOlxm3XlELCJQkJU+4aFrluaE0CCU7POyLfkGft6fJlMcIPHG/+kjHXjCmgXuU= X-Received: by 2002:ac2:42c7:: with SMTP id n7mr12293680lfl.65.1563225895908; Mon, 15 Jul 2019 14:24:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Mon, 15 Jul 2019 14:24:43 -0700 Message-ID: Subject: Re: PATCH: draw prompt on the correct line after window change To: Roman Perepelitsa Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" On Mon, Jul 15, 2019 at 10:21 AM Roman Perepelitsa wrote: > > I've tested this code only on GNOME Terminal. Before I go testing on a > dozen different terminals I'd like to get some feedback. Anything I'm > missing? Anything tricky to look out for? The most significant problem with window resizing is not the terminal itself, but window/session managers that try to do "live update" of the window contents as the cursor is rapidly dragged around. These tend to send a stream of WINCH signals which we have had to do various tricks to manage. I would be concerned that attempting to write a control sequence to the terminal and read back the response in the midst of a flood of such signals would fail as often as it succeeds. If this is already limited/controlled by the mechanisms in place, great. > The patch is attached to the email. You can also see it in > https://github.com/zsh-users/zsh/compare/master...romkatv:fix-winchanged. Thanks for the link, it's the only way I was able to see this on a mobile device. Please inline patches, or attach them as text/plain (not text/x-something), without base64 encoding if possible.