From: Marlon Richert <marlon.richert@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>, Oliver Kiddle <opk@zsh.org>
Cc: Vin Shelton <acs@alumni.princeton.edu>,
"Zsh Hackers' List" <zsh-workers@zsh.org>,
Jun T <takimoto-j@kba.biglobe.ne.jp>,
Bart Schaefer <schaefer@brasslantern.com>
Subject: Re: Y01 Test Failure on Arch
Date: Mon, 5 Apr 2021 17:58:44 +0300 [thread overview]
Message-ID: <CAHLkEDuSrpd2UitrjfscP_Kr5xBt+nXCp8enpyAopbY-G3HDmQ@mail.gmail.com> (raw)
In-Reply-To: <bf2c30eb-1a37-4c53-a019-a6fceb6625d4@www.fastmail.com>
On Sun, Apr 4, 2021 at 8:02 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Marlon, the failure is due to workers/48214, which is yours. Thoughts?
My original patch included the necessary changes to `comptest` to make
the tests work correctly. See
https://www.zsh.org/mla/workers/2021/msg00427.html (relevant part
included below). However, when I now do `git show
07a30613f0b0a5b782d30dbeb46df8382f8a4e2a`, it appears that Oliver left
those out of the actual commit.
Oliver, what was the reason you did not commit the changes below in 07a30613f?
diff --git a/Test/comptest b/Test/comptest
index a36e301e0..cdb3ecc61 100644
--- a/Test/comptest
+++ b/Test/comptest
@@ -40,6 +40,7 @@ KEYTIMEOUT=1
setopt zle
autoload -U compinit
compinit -u
+zstyle ":completion:*" completer _expand _complete _ignored
zstyle ":completion:*:default" list-colors "no=<NO>" "fi=<FI>"
"di=<DI>" "ln=<LN>" "pi=<PI>" "so=<SO>" "bd=<BD>" "cd=<CD>" "ex=<EX>"
"mi=<MI>" "tc=<TC>" "sp=<SP>" "lc=<LC>" "ec=<EC>\n" "rc=<RC>"
zstyle ":completion:*" group-name ""
zstyle ":completion:*:messages" format "<MESSAGE>%d</MESSAGE>
@@ -50,9 +51,9 @@ zstyle ":completion:*:options" verbose yes
zstyle ":completion:*:values" verbose yes
setopt noalwayslastprompt listrowsfirst completeinword
zmodload zsh/complist
-expand-or-complete-with-report () {
- print -lr "<WIDGET><expand-or-complete>"
- zle expand-or-complete
+complete-word-with-report () {
+ print -lr "<WIDGET><complete-word>"
+ zle complete-word
print -lr - "<LBUFFER>$LBUFFER</LBUFFER>" "<RBUFFER>$RBUFFER</RBUFFER>"
zle clear-screen
zle -R
@@ -80,11 +81,11 @@ zle-finish () {
(( $+mark )) && print -lr "MARK: $mark"
zle accept-line
}
-zle -N expand-or-complete-with-report
+zle -N complete-word-with-report
zle -N list-choices-with-report
zle -N comp-finish
zle -N zle-finish
-bindkey "^I" expand-or-complete-with-report
+bindkey "^I" complete-word-with-report
bindkey "^D" list-choices-with-report
bindkey "^Z" comp-finish
bindkey "^X" zle-finish
next prev parent reply other threads:[~2021-04-05 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 13:40 Vin Shelton
2021-04-01 4:05 ` Jun T
2021-04-03 11:32 ` Vin Shelton
2021-04-04 4:05 ` Jun. T
2021-04-04 14:00 ` Vin Shelton
2021-04-04 17:02 ` Daniel Shahaf
2021-04-05 14:58 ` Marlon Richert [this message]
2021-04-06 4:23 ` Jun T
2021-04-06 11:38 ` Marlon
2021-04-06 9:53 ` Oliver Kiddle
2021-04-04 18:27 ` Bart Schaefer
2021-04-05 0:39 ` Vin Shelton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLkEDuSrpd2UitrjfscP_Kr5xBt+nXCp8enpyAopbY-G3HDmQ@mail.gmail.com \
--to=marlon.richert@gmail.com \
--cc=acs@alumni.princeton.edu \
--cc=d.s@daniel.shahaf.name \
--cc=opk@zsh.org \
--cc=schaefer@brasslantern.com \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).