From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 32153 invoked from network); 17 May 2021 12:00:55 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 17 May 2021 12:00:55 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1621252855; b=AZR29SLkAU+7uE+KY+cS8z6iOerdOSc3X3d4MGy2/2pWAg1TqjTMop20dQ3N/U0g/3aALsxlVb 7WCuy4cxjlAYcFxauPUiS2Oh9N+hqus2X1nD7DSE05o2Pfmxq5Efw0ZJ1qlsPDvaAII1v3BiRm T6H792ehKdrZMR4LLn1yTsispyvP+CVbnb5D0MMqUy8+p3qhNkeJ1brkH6SpsRj7aGes6F9V3X zkMno5JsNAFcQyz36OiZzXdAL3ILiGzDlGBYfFnVVdQWBzZw8XJUJzHzdykMxzxYpnCkUmq/5z 9ElR0UAs5nHePq97owasxiWJPXhS2dFgjfiY6tW4eSiV9A==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lj1-f179.google.com) smtp.remote-ip=209.85.208.179; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1621252855; bh=8U4ygm65aOmK5aw0VlLEc9zXYWCszl59N4VVBI65lYs=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=y66ekHGo2/zlMkiaIaqookPYKq6sRDhiWJP6E1EZVvIMomq3i/RtXmBAjATHc/QaTcsZm3Q57v U241lI2ksGNW4sqUVPh7wadDjQfncYFiEn/yomMnSXV1DZJ61z6cdEndE2TxNN9le5BZ+PKRrC MEIWbFzSxStYagklUsLvpQoi8OLxFsyhoqdkaMMTIqvZ8Hbk5dye2vKDl2410q4j3JDmQDpbCK SPZwMDTo5cdE0Lm2KS7hd7WkakDXcUzhW9aUjyt9ko3qhY8BjFDW95ycWN6sty5RRHQL05kZiV toiqvsRCI1KkC0D1eEzqCJwfEAVmZN4bBAUjqWjvNe1Gaw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=OS8WKWIg+fqpmoxoqUvKk0vsf7gme7v13/chrDcDhgk=; b=RCmpA7KRIUNe5l63MlDcFVCHCA JdmxQYEDkU8XHffdYlzOgohp2tFEqhFNyhEIBaIQBhf3eUzp/DykMgO1ItgCayu8WxRPnvwIEmKc4 O7hQfQ6Qx1vCGOgNrFKlbaHU0w09WzeBOZMAMZFKmhf59ASW27qUONLkGDe0rbFgVJPsVQ88GNuV4 /HcbeuIrKxKeIil8rv1uq7sPa80Qg2aZV1FHupYqkO89ygZg1gaorDdSS4dqif6CR2CHjl5iWfwPV eOaohx76JcCXae77OqOqFBqFmhR2QXHNcGhv+J6jMY8t9c96+36amZjBvTsoCkTO2oc04BefybRvO ZgWNJEAQ==; Received: from authenticated user by zero.zsh.org with local id 1libvZ-000HAB-Jv; Mon, 17 May 2021 12:00:53 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lj1-f179.google.com) smtp.remote-ip=209.85.208.179; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lj1-f179.google.com ([209.85.208.179]:44624) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1libu3-000Gp0-KW; Mon, 17 May 2021 11:59:20 +0000 Received: by mail-lj1-f179.google.com with SMTP id s25so6842446ljo.11; Mon, 17 May 2021 04:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OS8WKWIg+fqpmoxoqUvKk0vsf7gme7v13/chrDcDhgk=; b=BPrveh1r8fsHm25keh78hwXziBUDzFBuVCWx02IkR3MbnydVEdG3LZ8iBg1U9wlfNp LoG4QH+4bhVWv/unjwcVV+KoWL4pHjuLKd6oGGbgjRIIPfU3paJeNcgQSRtt3R4ziQt/ rEhBKMZYkBmJuWZf7JJNa/BYZz6sqnYIAvotnabEePiMWMfMogPSJ71zLJX8SzCByzFj OzS7wjM1VDf5qEzHVBqobzxdO+rRGDBAb2ekyEIAdWNq74F3Dj7CURptZISe4McmSmgZ S3BFyhu4rR0uNZJ/szpZ4ddsTTvjv+7pvQVA//4VjlW/ZxSvdjrMuyDWpyvoFBBVcBqq SUaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OS8WKWIg+fqpmoxoqUvKk0vsf7gme7v13/chrDcDhgk=; b=fa8/OSabIKvM7xciJ8VOdIcqOHXyKogmhVNrfZDsPARUbOz//5scTXyfsBnjYQj2M+ IvgTYLTyTz4QESdZQftMXKPhtpDlUJ2D5m/BWKSNU3jswBDYts+87GHdTLV8nxHSrOri zEU5kDORHBLI7tnt9upyXczhlIttSIT1WBO5PDy73Vi9N99gYObUDzxpSJaqTRxpacPg 58S3XD9T321rSxrv9g7zPUlzYNpra5Uj4vRwZHvUMNVuQY6IsGVFx2SSPmagvAW/UHvu Vp6pW1BYHLu4ub8oRgQg6ytUuwCEBInD+TAf3RbmNqRThfNlmp4hKZqig6JHCBXDXE0W xdzQ== X-Gm-Message-State: AOAM533ECt0RBnbViF7H7C2PCVPr7/J4joLs5n4ZQbGRM9xmg/prVQsX YX1crDi+OcXRjKolTvivLT88JTttE6gDwcD+R6QYDB4jJN0= X-Google-Smtp-Source: ABdhPJyvYgcQtap2bmCjtdjSRy4bXka6mjmXTbvfBYfCjHyIv8KPUz1vte6iJPgh9uja8pzGLnWXFAKxaW9Nql7ew9I= X-Received: by 2002:a2e:87ce:: with SMTP id v14mr49326998ljj.28.1621252758501; Mon, 17 May 2021 04:59:18 -0700 (PDT) MIME-Version: 1.0 References: <45628-1621202954.654188@2yrG.1rQ3.yd3_> In-Reply-To: <45628-1621202954.654188@2yrG.1rQ3.yd3_> From: Marlon Richert Date: Mon, 17 May 2021 14:58:41 +0300 Message-ID: Subject: Re: [PATCH] Improve extra-verbose completion of array params To: Oliver Kiddle Cc: Zsh hackers list , Mikael Magnusson Content-Type: multipart/mixed; boundary="000000000000c32d0605c285529f" X-Seq: 48864 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: --000000000000c32d0605c285529f Content-Type: text/plain; charset="UTF-8" On Mon, May 17, 2021 at 1:09 AM Oliver Kiddle wrote: > > On 27 Apr, Marlon Richert wrote: > > This patch improves the extra-verbose completion display strings for > > arrays and associative arrays. > > - verbose=( > > - ${described[@]:/(#m)*/"${MATCH}:${(@q+)${(Pkv@q+)MATCH}//\\/\\\\}"} ) > > + verbose=( ${${${(f@)"$( typeset -m $described )"}/=/:}[@]//'\'/'\\'} ) > > Why the use of -m here? Is that to avoid it creating variables (which > may not matter especially in the subshell). Do we need to be concerned > about the possibility of glob characters appearing there and producing > more output than expected? Here's a new version of the patch, which hopefully addresses the concerns above and has a satisfactorily descriptive commit message. --000000000000c32d0605c285529f Content-Type: text/plain; charset="US-ASCII"; name="0001-Improve-extra-verbose-completion-display-strings-for.txt" Content-Disposition: attachment; filename="0001-Improve-extra-verbose-completion-display-strings-for.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kosjwbaw0 RnJvbSBlNzBjZjJiNGY0OGZjZTkwZjgzYTg5ZDI0ZTM2OWI5ZjVlYjEwZmQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJsb24gUmljaGVydCA8bWFybG9uLnJpY2hlcnRAZ21haWwu Y29tPgpEYXRlOiBNb24sIDE3IE1heSAyMDIxIDE0OjQ5OjAyICswMzAwClN1YmplY3Q6IFtQQVRD SF0gSW1wcm92ZSBleHRyYS12ZXJib3NlIGNvbXBsZXRpb24gZGlzcGxheSBzdHJpbmdzIGZvciBh cnJheQogcGFyYW1ldGVyIHZhbHVlcwoKLS0tCiBDb21wbGV0aW9uL1pzaC9UeXBlL19wYXJhbWV0 ZXJzIHwgMTYgKysrKysrKysrKy0tLS0tLQogVGVzdC9ZMDFjb21wbGV0aW9uLnp0c3QgICAgICAg ICB8IDE0ICsrKysrKysrKy0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyks IDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0NvbXBsZXRpb24vWnNoL1R5cGUvX3BhcmFt ZXRlcnMgYi9Db21wbGV0aW9uL1pzaC9UeXBlL19wYXJhbWV0ZXJzCmluZGV4IDAwYzE4MWUxMS4u NTQ5YjIxNTdiIDEwMDY0NAotLS0gYS9Db21wbGV0aW9uL1pzaC9UeXBlL19wYXJhbWV0ZXJzCisr KyBiL0NvbXBsZXRpb24vWnNoL1R5cGUvX3BhcmFtZXRlcnMKQEAgLTExLDkgKzExLDkgQEAgaWYg Y29tcHNldCAtUCAnKjonOyB0aGVuCiAgIHJldHVybgogZmkKIAotbG9jYWwgTUFUQ0ggaSBwZmls dAotbG9jYWwgLWkgTUJFR0lOIE1FTkQgbm09JGNvbXBzdGF0ZVtubWF0Y2hlc10KLWxvY2FsIC1h IGV4cGwgcGF0dGVybj0oLWcgXCopIG5vcm1hbCBkZXNjcmliZWQgdmVyYm9zZSBmYWtlZCBmYWtl cyB0bXAKK2xvY2FsIGkgcGZpbHQKK2xvY2FsIC1pIG5tPSRjb21wc3RhdGVbbm1hdGNoZXNdCits b2NhbCAtYSBleHBsIHBhdHRlcm49KCAtZyBcKiApIG5vcm1hbCBkZXNjcmliZWQgdmVyYm9zZSBm YWtlZCBmYWtlcyB0bXAKIAogenN0eWxlIC10ICI6Y29tcGxldGlvbjoke2N1cmNvbnRleHR9OnBh cmFtZXRlcnMiIHByZWZpeC1uZWVkZWQgJiYKICAgICBbWyAkUFJFRklYICE9IFtfLl0qIF1dICYm CkBAIC0yNyw4ICsyNywxMyBAQCBpZiB6c3R5bGUgLXQgIjpjb21wbGV0aW9uOiR7Y3VyY29udGV4 dH06cGFyYW1ldGVycyIgZXh0cmEtdmVyYm9zZTsgdGhlbgogICApCiAgIGNvbXBhZGQgIiRAIiAi JGV4cGxbQF0iIC1EIGRlc2NyaWJlZCAtYSAtIGRlc2NyaWJlZAogICBpZiAoKCAkI2Rlc2NyaWJl ZCApKTsgdGhlbgotICAgIHZlcmJvc2U9KAotICAgICAgICAke2Rlc2NyaWJlZFtAXTovKCNtKSov IiR7TUFUQ0h9OiR7KEBxKykkeyhQa3ZAcSspTUFUQ0h9Ly9cXC9cXFxcfSJ9ICkKKyAgICAjIE5v cm1hbGx5LCBjYWxsaW5nIHR5cGVzZXQgd2l0aG91dCBmbGFncyB3b3VsZCBwcmludCB0aGUgdmFs dWVzIG9mIGl0cworICAgICMgYXJndW1lbnRzLiBIb3dldmVyLCBpbnNpZGUgYSBmdW5jdGlvbiwg aXQgaW5zdGVhZCBkZWNsYXJlIGl0cyBhcmd1bWVudHMKKyAgICAjIGFzIGxvY2FsIHZhcmlhYmxl cyBhbmQgb3V0cHV0cyBub3RoaW5nLiBUaHVzLCB0byBmb3JjZSBpdCBwcmludCBvdXQKKyAgICAj IHBhcmFtZXRlciB2YWx1ZXMsIHdlIHBhc3MgaXQgdGhlIC1tIGZsYWcuCisgICAgdmVyYm9zZT0o IAorICAgICAgICAkeyR7JHsoZkApIiQoIHR5cGVzZXQgLW0gJHsoQGIpZGVzY3JpYmVkfSApIn0v PS86fVtAXS8vJ1wnLydcXCd9IAorICAgICkKICAgICBfZGVzY3JpYmUgLXQgcGFyYW1ldGVycyBw YXJhbWV0ZXIgdmVyYm9zZSAiJEAiICIkZXhwbFtAXSIKICAgZmkKIApAQCAtNTIsNCArNTcsMyBA QCBjb21wYWRkICIkQCIgIiRleHBsW0BdIiAtICIkbm9ybWFsW0BdIiAiJHsoQClmYWtlczp8ZGVz Y3JpYmVkfSIgXAogICAgICIkeyhAKSR7KEApJHsoQE0pZmFrZWQ6IyR7fnBhdHRlcm5bMl19fSUl Oip9OnxkZXNjcmliZWR9IgogCiAoKCBjb21wc3RhdGVbbm1hdGNoZXNdID4gbm0gKSkKLXJldHVy biAwCmRpZmYgLS1naXQgYS9UZXN0L1kwMWNvbXBsZXRpb24uenRzdCBiL1Rlc3QvWTAxY29tcGxl dGlvbi56dHN0CmluZGV4IDJjNmQyNWQ5YS4uODgyYTBhZGM0IDEwMDY0NAotLS0gYS9UZXN0L1kw MWNvbXBsZXRpb24uenRzdAorKysgYi9UZXN0L1kwMWNvbXBsZXRpb24uenRzdApAQCAtMjU1LDE1 ICsyNTUsMTggQEAgRjpyZWdyZXNzaW9uIHRlc3Qgd29ya2Vycy8zMTYxMQogPkZJOntmaWxlMX0K ID5GSTp7ZmlsZTJ9CiAKLSAgY29tcHRlc3RldmFsICJiYXI9KHskJ1xcMCcuLiQnXFxDLT8nfSk7 IGJhej1cJGJhciIKKyAgY29tcHRlc3RldmFsICJ0eXBlc2V0IC1hIGJhcj0oeyQnXFwwJy4uJCdc XEMtPyd9KSIKKyAgY29tcHRlc3RldmFsICd0eXBlc2V0IC1BIGJhdD0oICIkYmFyW0BdIiApJwor ICBjb21wdGVzdGV2YWwgJ3R5cGVzZXQgYmF5PSIkYmFyIicKICAgY29tcHRlc3RldmFsICd6c3R5 bGUgIjpjb21wbGV0aW9uOio6cGFyYW1ldGVycyIgZXh0cmEtdmVyYm9zZSB5ZXMnCi0gIGNvbXB0 ZXN0ZXZhbCAnenN0eWxlICI6Y29tcGxldGlvbjoqIiBmYWtlLXBhcmFtZXRlcnMgYmFyIGJhejph cnJheScKKyAgY29tcHRlc3RldmFsICd6c3R5bGUgIjpjb21wbGV0aW9uOioiIGZha2UtcGFyYW1l dGVycyBiYXIgYmF0IGJheScKICAgY29tcHRlc3QgJCc6ICRiYVx0JwogMDpleHRyYS12ZXJib3Nl IHNob3dzIHBhcmFtZXRlciB2YWx1ZXMKID5saW5lOiB7OiAkYmF9e30KID5ERVNDUklQVElPTjp7 cGFyYW1ldGVyfQotPk5POntiYXIgIC0tICdeQCcgJ15BJyAnXkInICdeQycgJ15EJyAnXkUnICde RicgJ15HJyAnXkgnICdcdCcgJ1xuJyAnXksnICdeTCcgJ15NfQotPk5POntiYXogIC0tICdeQCBe QSBeQiBeQyBeRCBeRSBeRiBeRyBeSCBcdCBcbiBeSyBeTCBeTSBeTiBeTyBeUCBeUSBeUiBeUyBe VCBeVSBefQorPk5POntiYXIgIC0tICggJ15AJyAnXkEnICdeQicgJ15DJyAnXkQnICdeRScgJ15G JyAnXkcnICdeSCcgJ1x0JyAnXG4nICdeSycgJ15MJyAnfQorPk5POntiYXQgIC0tICggWycgJ109 JyEnIFsnIiddPScjJyBbJyQnXT0lIFsnJiddPVwnIFsnKCddPScpJyBbJyonXT0rIFssXT0tIFsu XT0vfQorPk5POntiYXkgIC0tICdeQCBeQSBeQiBeQyBeRCBeRSBeRiBeRyBeSCBcdCBcbiBeSyBe TCBeTSBeTiBeTyBeUCBeUSBeUiBeUyBeVCBeVSBefQogCiAgIGNvbXB0ZXN0ZXZhbCAicGF0aD0o ICRaVFNUX3NyY2RpcjpBICkiCiAgIGNvbXB0ZXN0ZXZhbCAndHlwZXNldCAtSCBwYXRocz1ISURE RU4nCkBAIC0yODAsNyArMjgzLDggQEAgRjpyZWdyZXNzaW9uIHRlc3Qgd29ya2Vycy8zMTYxMQog PmxpbmU6IHs6ICRiYX17fQogPkRFU0NSSVBUSU9OOntwYXJhbWV0ZXJ9CiA+Tk86e2Jhcn0KLT5O Tzp7YmF6fQorPk5POntiYXR9Cis+Tk86e2JheX0KIAogICBjb21wdGVzdGV2YWwgJ190c3QoKSB7 IGxvY2FsIGRpc3A9KCB7YS4uen0gKTsgY29tcGFkZCAtbGQgZGlzcCAkZGlzcFtAXTsgY29tcHBv c3RmdW5jcz0oIF9wc3QgKSB9JwogICBjb21wdGVzdGV2YWwgJ19wc3QoKSB7IGxvY2FsIGRpc3A9 KCAiPElOU0VSVD4kY29tcHN0YXRlW2luc2VydF08L0lOU0VSVD4iICk7IGNvbXBhZGQgLVFsZCBk aXNwICRkaXNwIH0nCi0tIAoyLjMxLjEKCg== --000000000000c32d0605c285529f--