From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 1547 invoked from network); 29 Mar 2021 11:49:16 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 29 Mar 2021 11:49:16 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1617018556; b=bQD/GzGaA5khgbMUVKF94mWfdS1zUxClS1sK/D65dlWHDl462nq6vWO2mrxmsFn2azHKbI7UF+ LvIxANmQ8AoInCn4o9gulUqfj82VaXCKubaWPaddx5HOX3e6glx7vwyodywlQEqfLkJmzYLMC/ zK8n8Zg6XvgBstdJTMVsBDXV3n0ANZ6pEjvWJ1/VBbRmIxJ1V3LgrkKsyTRPiIobh/7K5oeU5E YKCHibsUT4U2qo4zDz9r94p98tVXZi8zPY+WKgQyeqAG+lnCeO4yCPDrZok3PlaiVyN2FmywLk 0xJUTBIKjrMTtINWVgpA6/wGfdXeFvRLJ9+RnYvZmiGJ9A==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-io1-f48.google.com) smtp.remote-ip=209.85.166.48; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1617018556; bh=28XuVyl+y1bu7cq8fbuhpErx7avrOS/w8OqBTDWOzAQ=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:References: In-Reply-To:MIME-Version:DKIM-Signature:DKIM-Signature; b=ff6TKVSQ8Ur/d3FKI+EYz0nwzX2epSHQpWcTNivwxKFWMCdFBcw0y6pBug2JQPcsaUYkvAu1kd fyJ+SpYwPcZi6i2vuO++2s6gVye56r588fZxBzQZXy1Djh0b4rooYunT0Fp461HCNWBOrX19z3 FDg0FL2tZLB725e1i9kKdKyZZALBFp2B/bHGrd5EO5rtvR0zx5KVO4P580dr+ueOphpFzsQqTW Egvj9aJ/bNkrrphg1pM6fhvMvGiTHUIMqK4kiSTLmLmKGRveI8bi2MSCfVLfFrLuAqeX5qx4hc fdcnKJkfUq3iCDcfIAcYKTMCD7MQ4lsm/mRzzLLLBCpHOg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:References:In-Reply-To:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=fsJYFd7akC3pO8/ZfZe74E0WA6t1KZjX8bC4S/846QY=; b=lOs3gu+uMCVU5K7gnloSL8iKlq wdBRW7VJe3Ry+VGdWsKxLp9Gxh7voS63KpRtGExjnGMAs2rW2dx1u1GyVDfQlHjZFr2YpRSnqrjxw +Z0f32LEQbirV+Ze1DToi4ptHZxw4gnhJQm91rlhaqXgCZgX2jbF6witBL4LrTQuJDROSEHeBIFeK 8k9TsVLH/mXiwj2BtkR++jx4dk4P2yrHK3F6ELP0thN1PZf6p591+Kyoza76MUiQn533DTxKmRDz+ NCLNL1g1IwTVbnZhJSE73oyrgpyxSuHENNhINPCnuA4cVOpA4Z5xwXoybVeELuKS7l1bLdvXzxXO6 DtMQcEeQ==; Received: from authenticated user by zero.zsh.org with local id 1lQqOP-0001Ld-7s; Mon, 29 Mar 2021 11:49:13 +0000 Authentication-Results: zsh.org; iprev=pass (mail-io1-f48.google.com) smtp.remote-ip=209.85.166.48; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-io1-f48.google.com ([209.85.166.48]:41912) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1lQqOB-0001Bg-56; Mon, 29 Mar 2021 11:48:59 +0000 Received: by mail-io1-f48.google.com with SMTP id z3so12395512ioc.8 for ; Mon, 29 Mar 2021 04:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fsJYFd7akC3pO8/ZfZe74E0WA6t1KZjX8bC4S/846QY=; b=nEyXKpG/sS4tZKPrgmU48LiKpEqNCdHKdxnySXFVdcUs+TYPlXo4b7VCN3g/yW/STk Hs7l4c3JN5AOeYmHiao4JHfsl090jWrbdYyzskXhYKwHBEvzQ5GlCVjdFwtld2jxfJFC RrMKDh+jqNOhN5la3r5FAB4ZQu+I54x81gQYns8Ozqwr4klmaux2k51Zx8T9O0abE8Ld YxK+tajHCdAvjKkh7IqR2GXYMdt3oAiWQXfoHafJUepa7pGcPxTQHWGKTh/tL/hccDzX 5P45ErtwzbHslkiY0pXbNVnwCrBHp2sUXd8XoczQk/kXjITWcJid7CUcSEzmrCwxurcU LbPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fsJYFd7akC3pO8/ZfZe74E0WA6t1KZjX8bC4S/846QY=; b=Yu4nHFRRzIUPyD5Yy5cq7k0rtRAHxjZVcHAI3qo+5cjuGyoEUszxNvlGH8H22s2zk8 S6YhhJTt+YOgVAPMbBaYFz/bauryhc6ELgTXIg7dRer1nwOHNPmvOpG8zRLyYfd8hur5 5HxILKuuTq15Jl+ZDgMYx4JJIX1dbYLxb9O+P1gcRUHKrY9XXi9/csE3zq02ghWDk3gG eMSFYQSxqJgIHzUOFbX59YAz1LuFdJRJ85z1qfXF+0mmp850LawszqKlfRYS2BiC7FRg DIR+Jzj2E/e38T2NQJbJnCAPMiGJsTkl7ohDbFEH9AsB0juNH6PWg4HCQfsguA6AuHEJ RoBQ== X-Gm-Message-State: AOAM533zyecmN1E9P6twDqFbatJg8pqj+XQMuiupNcnv+SNT2Fqjyqzo SPJ+uqtdCCrIlZmgPrzxChkJgTsuLJaKYnwJhig= X-Google-Smtp-Source: ABdhPJx5KV721bV99x2anEw7SD0lWk+BVKX5gXOjtI/sKpeIaIEI1aWXyzKpjhGSVZc/JOmtie7UpjVaUbzfd3sVtTA= X-Received: by 2002:a6b:7e02:: with SMTP id i2mr19407067iom.120.1617018538153; Mon, 29 Mar 2021 04:48:58 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:f4d:0:0:0:0:0 with HTTP; Mon, 29 Mar 2021 04:48:57 -0700 (PDT) In-Reply-To: References: From: Mikael Magnusson Date: Mon, 29 Mar 2021 13:48:57 +0200 Message-ID: Subject: Re: Feature Patch: Use completion to view parameter values To: Marlon Richert Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 48314 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On 3/28/21, Marlon Richert wrote: > diff --git a/Completion/Zsh/Type/_parameters I may only be speaking for myself here, but please always include a commit message in patches. Trying to reverse engineer your intent from the patch body and then reviewing it to see how the patch differs from that intent is somewhat impossible (and "Use completion to view parameter values" is pretty vague). I'm assuming this is some sort of RFC since you didn't include any documentation patch, so then it is even more helpful to have some description of what you're trying to do. -- Mikael Magnusson