From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 3983 invoked from network); 3 Aug 2022 14:42:19 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 3 Aug 2022 14:42:19 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1659537739; b=ckLrAS7kddVpXADYcEf6zWyuOPxFqcSo1wK2VCi1puKpDhZ0yxZkRjbFVZuJnML9UNQ9CmZxSP q1kXLebWBJRGy+rlH1FrHGmOhkLTsLD8/13GgQbY2SHpcFgquQaL4xji5a5AiO5+5D1ipNUGba osH26R2WHmsSvOUVgM2UTKs568+Zrr85jUuzxmMQpiFwj8TD8CjPF7e/D2VL7s65w1J5HTztwD jKBjfiH9qvIAMczeXQEJ3EGLJDe4ZI7fs/XGlCuFtezct609FgZjsZYjkenG9diUADqph8SRaQ Gw10dU4h1PGpCMOF4AgUfEJZTHiP46Cvs8eWtwxlhBj/fg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f43.google.com) smtp.remote-ip=209.85.218.43; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1659537739; bh=bhUuWCp7b7SkZnVSJIFzgm6oKSbs/aQ0AlPBWIwOFqA=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=stmvlGkz9orDQRXlq20be2Q7U7+9i0seroQ7dd9xNUqkaC+CigAxm8F4abpeMj/Tx1v6doaZEI tOpQ76kU3kk0m2fDR8BJneuKp6TToFMrdT/VGRL/ArI8DyBDN3BViYK1Ij/kLjMVud33ZHey/v d1saT7PPtsbzYZwqxEcsfCVc54SnBAwc3rS66Jhp5APUrgw2xW5177RQD9xYxUpTbP2pDDv1ik AGg1TUH6yQQz8BXP4ElcH/YT2mNmblXGhA/TPDXab67pRAr+Y/1LA3FSz98gX0tw93PufI3YMj 0z1uU4CKvPQfu8crCS9YT0aVNACIZuLIV5C6GG/p5bKoeQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=AQZDVnoZkSUTWbpATBMwaJ+yXkQJ+gfVXs5q1KjdQ1w=; b=qGNe3WI6iArw1zfgtriXDqycr+ 1ILSUUuQ1Hf0IvBcF0II8K6QS3As1WSFHS6jeHr1n7b57FMJAwuZQueMTSdEF9k+bkgD2M26aOT2T iFJoRO6VFyeNSxksiZOXIrHgVYEccbw6a7DkghRc/+MBKswUnYloC7Ev3DUkusdpDTPQznmz8aUAU HUVK6rFTYC0SeEZUjx/a9AJr1f5ZRaOKxYRWOgzKCAsGd6yLZHD/W1kOfTZY/R227tP1gjxbh+wU3 LboqFQEWyzcpQ4f3XZLmly1b9DY44D1DI9LpNa1w9Bx+qDkuQg8YJ2OcSyDSng3hBjG+XByCnKeID StHTPZGg==; Received: from authenticated user by zero.zsh.org with local id 1oJFZi-0004ln-2c; Wed, 03 Aug 2022 14:42:18 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f43.google.com) smtp.remote-ip=209.85.218.43; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ej1-f43.google.com ([209.85.218.43]:44722) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oJFUX-0004Jz-Gt; Wed, 03 Aug 2022 14:36:58 +0000 Received: by mail-ej1-f43.google.com with SMTP id c24so1071877ejd.11 for ; Wed, 03 Aug 2022 07:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=AQZDVnoZkSUTWbpATBMwaJ+yXkQJ+gfVXs5q1KjdQ1w=; b=VpNt6M4frbtiXAOiZd+JXC+oJCB8/xqXqukI8D/W9VtmG9mkjb3LuwJvLl3xvUBLbS 86YL68edUwDo5wPLh1JO1BJWzAg+4mNmQd7P6ZY97khMIKT4IcaKDcBOFShFkYP4kprJ vfL4Xc5WVaUSr2aBuI8ZUaPf6hxgIf+HfSeNVGY0qaXxZo39NkTMY48buHKta53t9B7b vniMBeSOuHaKV8BlPaH/wse8IvCqCFBO4TDHxBmXqlobpDbo6t52oVrZ6GaiS/VZ1Rmm 5yYlKLGKDHpqjYTGdjtZVtDYLF57+wJA0sExwACTOUjXNDcw3D0v2zx/lRrljci+QRbe j99Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=AQZDVnoZkSUTWbpATBMwaJ+yXkQJ+gfVXs5q1KjdQ1w=; b=qBywKiUz/eNMERNdwiOi7FBzoTy4Yk7HuxkJcgjwrWCXPLvQB4KahyRPJsgXBcorUf Os2oNEDEb8QMBHA+gv+hgwW868gn4DuRA6zl9zcFtI8xj5O3qtBgtL6797bOVNG6Zrhq SpnWH+OG/ynNKSv29A1FcqvlyfJtaQ7ITg7OfFvUkK9N82HCz6xK78eBWFRyxMyKOxlU 24N+Ip0K8Lb3Lf//pis5jBxKoM3+k1WJHgLGlLn8GoBKu+pXjzuRMEIQIsLhC0mTLbvl q2X+/z4GfA7gsl+5BHhN430iQa2WIyPaP3KWkPED0NOx9kytRp/J8GH7rmxZeBD4IORt TK/Q== X-Gm-Message-State: AJIora/mSmqVLyYaUIwBkv9XvybBD/d/kDognDaNxJBs6mCEvOzFdE31 opIgVby56RvGPxA93xskgFIvgud8tj+TO73BDjMeteyf X-Google-Smtp-Source: AGRyM1v0VBBY1CcyDI2fbYoI9DTmla1JAON2HmIQDJNqhd9wHfIcLRIRyTGNZ3eTVVqTEnEHpkGrrwz9QTGVY3SGFCU= X-Received: by 2002:a17:907:3d94:b0:72b:54bc:aa38 with SMTP id he20-20020a1709073d9400b0072b54bcaa38mr20651881ejc.679.1659537417079; Wed, 03 Aug 2022 07:36:57 -0700 (PDT) MIME-Version: 1.0 References: <20220730010310.3383526-1-felipe.contreras@gmail.com> In-Reply-To: From: Felipe Contreras Date: Wed, 3 Aug 2022 09:36:46 -0500 Message-ID: Subject: Re: [PATCH 0/3] completion: make: various improvements To: Jun T Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 50442 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Wed, Aug 3, 2022 at 3:54 AM Jun T wrote: > > > 2022/08/03 8:02, Felipe Contreras wrote: > > > > On Tue, Aug 2, 2022 at 5:43 AM Jun T wrote: > > >> # Not a target: > >> > >> I think a (wrong) target after this line should be ignored. > > > > The current code which uses _make-parseMakefile already offers those > > targets anyway, so there is no change. > > If 'call-command' style is set to false, then these targets are not > offered (as a possible target). But if you set it to true they are. We are talking about the *current code*. The current code already has this behavior. > > Personally I don't like the current design, which is why I don't use > > the official make completion, and use my own instead [1]. I think only > > the targets returned by make should be completed (no _files), > > You may try the following: > > zstyle ':completion:*:make:*:' tag-order 'targets variables' Sure, in that case those files won't be listed initially, but they still will be completed. -- Felipe Contreras