From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 27240 invoked from network); 13 Oct 2020 11:06:09 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 13 Oct 2020 11:06:09 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1602587169; b=sVRg5GsYgOVPI5zxDQdNzgj/nFI1uE8JObuDKHgr4bAOcjllVfWm/iP+78u2fqsn6uX5rtblYM NuJ3V74GlkwieLUCNsxUhLZN+BzU2oswhwmYz9BtW5BJWaD45f0NqSwwEetengwgyDWsH3OyoK QzspNDS3fT+51JxoHXtDS98PvNwm0h9ff2KvZUhGhVTLHBEk8XoYdxtyWoccl0HCofPwoUitcm 8aDdG9PF0GOKOOjoDspYs5ADJ9S77ya8ZwgmXfrPsZyDLivR5R2ibrRubEB72bBx2JzxnQPgzS YLIJYi9QJufo2ip8/cCz9tMb8vbysgKyGUvqXYHD0gVWPA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-io1-f48.google.com) smtp.remote-ip=209.85.166.48; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1602587169; bh=TkTR9VvKjQBwEx0ebZFdWX4vCWRh8rhBa0e2onrpX+4=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=i75F6I+cVaZlRBWIKuBSA6Msy1CysME0g76RHL8S1XxlEoGCh1Zp+nFhwcEtMoHCyeMcfqV707 i6i0Opwebdlx7EHeFNZsLCjRN2IgFm2b3P/cqUgDYCalH39LasQjydAQNW+OkCPXi4VLXR9YQu gaeko+0DLoodGaalpEbcv7XpmAdrY1peA4O5L6tyFkWeklp+5WxkSH6erakzO607SRAZ+9Y90D LARO2oivLVfUJ5ZGNtveNF7ae6EK7oE13fViwIjTX38AujkYe5nJXsyW4ThQkI3H2lUBB/790F rnutxJeb5XxeWvSpkG8WZI3cGSv7Cfdi7dymUTL9FVnOYQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=gUAgiZknIE32zrckLmvSs40x1qnD3lPjOXER7VulFmQ=; b=ObLknTH2XieKMnzyWyORMuG2Z8 PDLwx9BtxAvJNFs16FE7T2rrKm5/E0bTy2n2IdHwC3utjhmvGRJj7sktDaQsy+E8zkr/zkOmByNBd qCxE5wXXG2HPK/CcSwC3U0DptfXdY4CipyXTjlcn9S0jeYoNC6CmJvhoSHQviYKzPaPyShsUTY/tS RLf9E4kg13n0Md3X3fmCVzciHCBQRnLKh1zwZjfSnJTP27OCSoS6NZLp+xjCzQ/wKwWF65gNZ8P7Q p87Y+LkOTHgoCvb2wGVpA2L4vCbpCfj+IUVFWidKYSyzlGb/Lqhua510qTAp0DbZG0gnYAIo1BrAs hVmjpV7Q==; Received: from authenticated user by zero.zsh.org with local id 1kSI87-000P3Z-NJ; Tue, 13 Oct 2020 11:06:07 +0000 Authentication-Results: zsh.org; iprev=pass (mail-io1-f48.google.com) smtp.remote-ip=209.85.166.48; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-io1-f48.google.com ([209.85.166.48]:36879) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1kSI7q-000Ov6-Ed; Tue, 13 Oct 2020 11:05:52 +0000 Received: by mail-io1-f48.google.com with SMTP id q25so7777330ioh.4 for ; Tue, 13 Oct 2020 04:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gUAgiZknIE32zrckLmvSs40x1qnD3lPjOXER7VulFmQ=; b=tEpjPVZVXEK1qI/yq1MgGySttrsi2Dt4+PrnWbE4tnHr+TZkBdNQJFWoiV6CoD9Bt+ kwXvug9ZOBNmbyqi+77GKtRMLDQBTgjvVSbGGmS/u+xC16LSOhjkXX6+Kg9LGDnxMbwV FKbcgsGHDGWGe7fhOI5/17cQdBffMHy0a1H3jeXZ8seD5I+X/O/jemqJ7ouaLqrWCdZV rAPK3+DN4WtbgKVxm+Q2Mh0wUIxUoesx6wqsNvWOIw5PgGj2Pld1UxYV8v/I6VB2vhEU D7Axc/9WnmnyZL4RHcRtm2/YvV+RtuwC082i7MkWa6AKzd+RoXkGdnFAI3qDIZOcNusc 3ZUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gUAgiZknIE32zrckLmvSs40x1qnD3lPjOXER7VulFmQ=; b=BGTO2OTcQqsdPBbf2pTR4U1FgezHWQchdJihqmxEKNuN4vXQ4EL091efF/3XKnXBMT 5Q0X8o5CqIC3CPg25CEW9RY3PSEif1MC8lWEaEV5RaMJf9ng/8hQvkBQzBxd5gsA4Xd+ S0uWzrqNzEV7FODp+kix71bQIW+MTIXa2D3KH+62ARBYx/7UPNohE2A0TtmPW1EJe9cJ 2+rB6MproOi67nmYjZd4r8ZE8WugQUJCTTTmxS+zjZKS6GqhYW7Lje4PYWfCEV5pAwY4 +FLujyDMvx8Z3ZmIbVNkGXYzHPlznww+AgBQPluoeRCdAsRxujUNGC3JraGDG7ffhS+H ElOw== X-Gm-Message-State: AOAM533HsAiVQdzBc302FFHO7/J6rAWTJaDh2ZtF4qKZtK4NNQp8kH4j p92Ru5gIc/uwA64YJxoho2RQv9CHicQaAkSosG8= X-Google-Smtp-Source: ABdhPJy6ulCWxNASgIx0tDYh9BgL186tCqFXYEWqIskt3vN66+Mqonpr5ZC2jNnTyS310CR1+bwhxgXHV5fKBV0p74c= X-Received: by 2002:a02:c8d1:: with SMTP id q17mr23132551jao.127.1602587149123; Tue, 13 Oct 2020 04:05:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Roman Perepelitsa Date: Tue, 13 Oct 2020 13:05:39 +0200 Message-ID: Subject: Re: region_highlight converts `fg=default` to `none`, which is not the same To: Marlon Richert Cc: Zsh hackers list Content-Type: multipart/mixed; boundary="000000000000bee79105b18b65b1" X-Seq: 47446 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: --000000000000bee79105b18b65b1 Content-Type: text/plain; charset="UTF-8" On Mon, Oct 12, 2020 at 11:23 AM Marlon Richert wrote: > > 1. It seems incorrect to convert `fg=default` to `none`. From reading the [documentation](http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting), `none` is not supposed to be the same as `fg=default`. I took a quick look at this yesterday. When you print region_highlight and "fg=default" comes out as "none", that's a bug in the printing logic (function output_highlight in Src/prompt.c). It's fairly easy to fix -- patch below (only for fg; bg should be handled similarly). Naturally, it doesn't solve the other issues you've described. I haven't looked at why the highlight doesn't get applied as it should be. Roman. P.S. zsh-workers is the correct mailing list for this discussion. --000000000000bee79105b18b65b1 Content-Type: text/plain; charset="US-ASCII"; name="output-highlight-patch.txt" Content-Disposition: attachment; filename="output-highlight-patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kg7uyy7s0 ZGlmZiAtLWdpdCBhL1NyYy9wcm9tcHQuYyBiL1NyYy9wcm9tcHQuYwppbmRleCA5OTczMjdlMTgu LjM2YzgyODMyMSAxMDA2NDQKLS0tIGEvU3JjL3Byb21wdC5jCisrKyBiL1NyYy9wcm9tcHQuYwpA QCAtMTg0Miw2ICsxODQyLDEzIEBAIG91dHB1dF9oaWdobGlnaHQoemF0dHIgYXRyLCBjaGFyICpi dWYpCiAJYXRybGVuICs9IGxlbjsKIAlpZiAoYnVmKQogCSAgICBwdHIgKz0gbGVuOworICAgIH0g ZWxzZSBpZiAoYXRyICYgVFhUTk9GR0NPTE9VUikgeworCWxlbiA9IDEwOworCWF0cmxlbiArPSBs ZW47CisJaWYgKGJ1ZikgeworCSAgICBzdHJjcHkocHRyLCAiZmc9ZGVmYXVsdCIpOworCSAgICBw dHIgKz0gbGVuOworICB9CiAgICAgfQogICAgIGlmIChhdHIgJiBUWFRCR0NPTE9VUikgewogCWlm IChhdHJsZW4pIHsK --000000000000bee79105b18b65b1--