From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <003401c10e32$2ce826d0$0100a8c0@winserv> From: "Michael Grunditz" To: <9fans@cse.psu.edu> References: <20010716195334.36D2F19A32@mail.cse.psu.edu> <002801c10e31$a9d528b0$0100a8c0@winserv> Subject: Re: [9fans] I still dont understand... MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Date: Mon, 16 Jul 2001 22:02:00 +0200 Topicbox-Message-UUID: cf71ad8a-eac9-11e9-9e20-41e7f4b1d025 again.. What I wanted to say was that I allready worked around those two bugs.. /Michael ----- Original Message ----- From: "Michael Grunditz" To: <9fans@cse.psu.edu> Sent: Monday, July 16, 2001 9:58 PM Subject: Re: [9fans] I still dont understand... > But .. comments in source > > /Michael > ----- Original Message ----- > From: "David Gordon Hogan" > To: <9fans@cse.psu.edu> > Sent: Monday, July 16, 2001 9:53 PM > Subject: Re: [9fans] I still dont understand... > > > > There are some bugs in the upas/fs plaintext POP implementation, which > > probably weren't detected because upas/fs insists on APOP if the server > > supports it. Here's a patch for them. Note that there is another bug -- > upas/fs > > will die if your POP mbox has 0 messages. I haven't got around to fixing > that. > > > > /n/dump/2001/0716/sys/src/cmd/upas/fs/pop3.c:132,133 c > /n/dump/2001/0705/sys/src/cmd/upas/fs/pop3.c:132,133 > > < sprint(buf, "/mnt/auth/pop/%s/%s", pop->host, pop->user); > > < if((fd = open(buf, OREAD)) < 0) > > > This doesnt work ,its now it fails... ie , this > > if((fd = open(buf, OREAD)) < 0) > > I have allredy tried that > > > --- > > > sprint(buf, "/mnt/auth/pop3/%s/%s", pop->host, pop->user); > > > if((fd = open(buf, ORDWR)) < 0) > > /n/dump/2001/0716/sys/src/cmd/upas/fs/pop3.c:469 c > /n/dump/2001/0705/sys/src/cmd/upas/fs/pop3.c:469 > > < int nf, ppop; > > --- > > > int nf; > > /n/dump/2001/0716/sys/src/cmd/upas/fs/pop3.c:472,473 c > /n/dump/2001/0705/sys/src/cmd/upas/fs/pop3.c:472 > > < ppop = strncmp(path, "/pop/", 5) == 0; > > < if(!ppop && strncmp(path, "/apop/", 6) != 0) > > --- > > > if(strncmp(path, "/pop/", 5) != 0 && strncmp(path, "/apop/", 6) != 0) > > /n/dump/2001/0716/sys/src/cmd/upas/fs/pop3.c:491 c > /n/dump/2001/0705/sys/src/cmd/upas/fs/pop3.c:490,491 > > < pop->ppop = ppop; > > --- > > > if(strncmp(path, "/pop/", 5) == 0) > > > pop->ppop = 1; > > > > > This doesnt fail here .. >