From mboxrd@z Thu Jan  1 00:00:00 1970
From: erik quanstrom <quanstro@quanstro.net>
Date: Tue,  5 Feb 2013 10:38:54 -0500
To: 9fans@9fans.net
Message-ID: <01b90367d1b21dd4d899771ed5189c3a@kw.quanstro.net>
In-Reply-To: <09803b4d93511fdb3e2232a9759e5aa8@isd.dp.ua>
References: <09803b4d93511fdb3e2232a9759e5aa8@isd.dp.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [9fans] APE libsec
Topicbox-Message-UUID: 15112c04-ead8-11e9-9d60-3106f5b1d025

looks good, but i'd do libsec at the same time.
unless you know of a compelling reason for these
to support a different set of algorithms?

- erik

 ; diffy -c /sys/src/libsec/port/x509.c /sys/src/ape/lib/sec/port/x509-ape.c
diff -c /n/dump/2013/0205/sys/src/libsec/port/x509.c /sys/src/libsec/port/x509.c
/n/dump/2013/0205/sys/src/libsec/port/x509.c:1582,1587 - /sys/src/libsec/port/x509.c:1582,1589
  	ALG_md5WithRSAEncryption,
  	ALG_sha1WithRSAEncryption,
  	ALG_sha1WithRSAEncryptionOiw,
+ 	ALG_sha256WithRSAEncryption,
+ 	ALG_shaWithRSASignatureOiw,
  	ALG_md5,
  	NUMALGS
  };
/n/dump/2013/0205/sys/src/libsec/port/x509.c:1595,1600 - /sys/src/libsec/port/x509.c:1597,1604
  static Ints7 oid_md5WithRSAEncryption = {7, 1, 2, 840, 113549, 1, 1, 4 };
  static Ints7 oid_sha1WithRSAEncryption ={7, 1, 2, 840, 113549, 1, 1, 5 };
  static Ints7 oid_sha1WithRSAEncryptionOiw ={6, 1, 3, 14, 3, 2, 29 };
+ static Ints7 oid_sha256WithRSAEncryption ={7, 1, 2, 840, 113549, 1, 1, 11 };
+ static Ints7 oid_shaWithRSASignatureOiw ={6, 1, 3, 14, 3, 2, 15 };
  static Ints7 oid_md5 ={6, 1, 2, 840, 113549, 2, 5, 0 };
  static Ints *alg_oid_tab[NUMALGS+1] = {
  	(Ints*)&oid_rsaEncryption,
/n/dump/2013/0205/sys/src/libsec/port/x509.c:1603,1608 - /sys/src/libsec/port/x509.c:1607,1614
  	(Ints*)&oid_md5WithRSAEncryption,
  	(Ints*)&oid_sha1WithRSAEncryption,
  	(Ints*)&oid_sha1WithRSAEncryptionOiw,
+ 	(Ints*)&oid_sha256WithRSAEncryption,
+ 	(Ints*)&oid_shaWithRSASignatureOiw,
  	(Ints*)&oid_md5,
  	nil
  };
diff -c /n/dump/2013/0205/sys/src/ape/lib/sec/port/x509-ape.c /sys/src/ape/lib/sec/port/x509-ape.c
/n/dump/2013/0205/sys/src/ape/lib/sec/port/x509-ape.c:1582,1587 - /sys/src/ape/lib/sec/port/x509-ape.c:1582,1589
  	ALG_md5WithRSAEncryption,
  	ALG_sha1WithRSAEncryption,
  	ALG_sha1WithRSAEncryptionOiw,
+ 	ALG_sha256WithRSAEncryption,
+ 	ALG_shaWithRSASignatureOiw,
  	ALG_md5,
  	NUMALGS
  };
/n/dump/2013/0205/sys/src/ape/lib/sec/port/x509-ape.c:1595,1600 - /sys/src/ape/lib/sec/port/x509-ape.c:1597,1604
  static Ints7 oid_md5WithRSAEncryption = {7, 1, 2, 840, 113549, 1, 1, 4 };
  static Ints7 oid_sha1WithRSAEncryption ={7, 1, 2, 840, 113549, 1, 1, 5 };
  static Ints7 oid_sha1WithRSAEncryptionOiw ={6, 1, 3, 14, 3, 2, 29 };
+ static Ints7 oid_sha256WithRSAEncryption ={7, 1, 2, 840, 113549, 1, 1, 11 };
+ static Ints7 oid_shaWithRSASignatureOiw ={6, 1, 3, 14, 3, 2, 15 };
  static Ints7 oid_md5 ={6, 1, 2, 840, 113549, 2, 5, 0 };
  static Ints *alg_oid_tab[NUMALGS+1] = {
  	(Ints*)&oid_rsaEncryption,
/n/dump/2013/0205/sys/src/ape/lib/sec/port/x509-ape.c:1603,1608 - /sys/src/ape/lib/sec/port/x509-ape.c:1607,1614
  	(Ints*)&oid_md5WithRSAEncryption,
  	(Ints*)&oid_sha1WithRSAEncryption,
  	(Ints*)&oid_sha1WithRSAEncryptionOiw,
+ 	(Ints*)&oid_sha256WithRSAEncryption,
+ 	(Ints*)&oid_shaWithRSASignatureOiw,
  	(Ints*)&oid_md5,
  	nil
  };