From mboxrd@z Thu Jan  1 00:00:00 1970
From: erik quanstrom <quanstro@quanstro.net>
Date: Wed, 18 Jun 2014 14:44:44 -0400
To: 9fans@9fans.net
Message-ID: <04f2b52923ba905dcb19a4d047f0e118@brasstown.quanstro.net>
In-Reply-To: <ac140ab82bbe7f0c4c62afeaa9942eab@brasstown.quanstro.net>
References: <0F299083-D3D8-456F-AD09-350117E95B9B@fb.com>
	<CAK4xykX8rgzS57B6Pm17HfQkffPGa8RnSVczhBknzrUM=_0=vQ@mail.gmail.com>
	<861c79d1a310a6b4af938597e50d0cf6@brasstown.quanstro.net>
	<229B5D7C-7229-4C18-8967-3D1FC9AFD373@fb.com>
	<ac140ab82bbe7f0c4c62afeaa9942eab@brasstown.quanstro.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [9fans] possible buffer overflow in devcons.c?
Topicbox-Message-UUID: fb650bf8-ead8-11e9-9d60-3106f5b1d025

On Wed Jun 18 14:20:02 EDT 2014, quanstro@quanstro.net wrote:
> On Wed Jun 18 14:15:14 EDT 2014, pad@fb.com wrote:
> > Well, hard to grep for '3' in a big codebase. They should have used UTFMAX in the first place.
> >
>
> it's not hard.  i did this once.  i think i did something like this
>
> 	g 'char[ 	]+[a-z]+\[(3|4|3\+1)\]' /sys/src

er, better to have

	g '( |	|^)char[ 	]+[a-z]+\[(3|3 *\+ *1)\]' /sys/src

it looks like 9atom is clean.  i haven't checked sources.  but that
reminds me i have to kill that private copy of devcons in omap.

- erik