From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <06abac94216027a88f669cd81b5ed6b1@akira.nop.cx>
To: brantley@coraid.com
Subject: Re: [9fans] drawterm
From: Tim Wiess <tim@nop.cx>
Date: Fri,  4 Nov 2005 15:08:51 -0800
In-Reply-To: <4e28f7a872bb2d9da1a1cb16019380b1@coraid.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Cc: 9fans@cse.psu.edu
Topicbox-Message-UUID: a6529fe8-ead0-11e9-9d60-3106f5b1d025

> i just downloaded it.  ran it under fc4 and it drops core.
> now, if i can just find out where they put the core file!!

I noticed that it seg faults when you don't specify an auth server. Due
to a null dereference in netmkaddr(authserver, "tcp", "567") from
authdial().

I added the patch below to fix it as well as provide support for $auth.


Index: cpu.c
===================================================================
RCS file: /cvs/drawterm/cpu.c,v
retrieving revision 1.3
diff -u -r1.3 cpu.c
--- cpu.c	4 Nov 2005 17:06:57 -0000	1.3
+++ cpu.c	4 Nov 2005 22:59:48 -0000
@@ -181,6 +181,12 @@
 			fatal(0, "set $cpu");
 		system = p;
 	}
+	if(authserver == nil) {
+		p = getenv("auth");
+		if(p == 0)
+			fatal(0, "set $auth");
+		authserver = p;
+	}
 
 	if(err = rexcall(&data, system, srvname))
 		fatal(1, "%s: %s", err, system);